Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

com.example.batch.CreateResourcesIT: remove @Ignore from tests #9855

Open
telpirion opened this issue Dec 11, 2024 · 0 comments
Open

com.example.batch.CreateResourcesIT: remove @Ignore from tests #9855

telpirion opened this issue Dec 11, 2024 · 0 comments
Labels
api: batch Issues related to the Batch API. priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@telpirion
Copy link
Contributor

The integration tests for the Batch samples were disabled in #9841.

Reason:

The samples clean up logic requires regular polling of each Job created in the test file. Jobs can take ~2-4 minutes to complete. The polling logic allows for regular retries up until 1200 seconds before erroring out. Unfortunately, not all of the jobs are marked as SUCCEEDED or FAILED in the time provided.

The Batch API has a CancelJob method that is available in v1alpha but not v1. Once this method is available to the v1 channel, we should be able to cancel a job after it has been created and then delete it.
@telpirion telpirion added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. triage me I really want to be triaged. labels Dec 11, 2024
@product-auto-label product-auto-label bot added api: batch Issues related to the Batch API. samples Issues that are directly related to samples. labels Dec 11, 2024
@telpirion telpirion mentioned this issue Dec 11, 2024
Merged
@telpirion telpirion removed their assignment Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: batch Issues related to the Batch API. priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@telpirion