Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add histogram for response time percentiles #3

Open
JorritSalverda opened this issue Mar 16, 2018 · 2 comments
Open

Add histogram for response time percentiles #3

JorritSalverda opened this issue Mar 16, 2018 · 2 comments
Labels
enhancement New feature or request

Comments

@JorritSalverda
Copy link

The current response time summary can't be aggregated over multiple machines so it's hard to graph response time percentiles. A histogram with configurable buckets would be very useful to add. See https://prometheus.io/docs/practices/histograms/

@mateusz-jablonski94
Copy link
Contributor

Hi,

We decided to use summary metrics, because computing quantiles is done on client-side.
That results in low server-side cost, which was our main priority.
Thanks for the feedback, we will think about it.

@mateusz-jablonski94 mateusz-jablonski94 added the enhancement New feature or request label Oct 23, 2018
@JorritSalverda
Copy link
Author

According to https://www.robustperception.io/how-does-a-prometheus-histogram-work the histogram is actually cheaper than a summary, although the use of the word client in the blog post is confusing.

In addition to being aggregatable, histograms are cheaper on the client too as counters are fast to increment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants