-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use DataFrames as input for performance_profile()
#48
Comments
I believe this is very similar to |
Sure! |
@lrsantos11 What would be the advantage of pushing data into a DataFrame as opposed to an array? The function in SolverBenchmark extracts data from a DataFrame into an array... |
I understand that many have been keeping their results using DFs. Perhaps moving or copying the performance_profile function in SolverBenchmark.jl as mentioned by @tmigot as it seems to be the solution I was looking for. The advantage is that one do not need to call another package to use this feature. I thinkg there is no performance (no pun intended) improvement using DFs whatsoever, yet usability will be improved, in my opinion. |
I don’t see any problems with that. @abelsiqueira, how about you? @lrsantos11 do you want to submit a PR to each repo? |
I'm happy with it too. |
Using data frames from DataFrames.jl as input for
performance_profile()
would be usefull.Perhaps, the syntax could be to have a DataFrame as
then push to
df
the data from each solver and callperformance_profiles(df)
which would use the column name from
df
as name of the solver, if note given by the user.The text was updated successfully, but these errors were encountered: