Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for two pollutants #4

Open
brunj7 opened this issue Jul 28, 2021 · 1 comment
Open

Adding support for two pollutants #4

brunj7 opened this issue Jul 28, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@brunj7
Copy link
Member

brunj7 commented Jul 28, 2021

From Claire:

The goal of the change we are implementing is to be able to define two PM2.5 pollutants in each simulation (PM2.5 from wildfires and PM2.5 from prescribed burns).

The way we will accomplish this is by defining two pollutants in the CONTROL file (this will be part of the template and will not change run to run) and then in the EMITIMES file we need to have one line per pollutant for each location. So ultimately, we need 2 lines for each emissions release location, with one line being a dummy line for either wildfire or prescribed burn- PM2.5.

How we've set it up is that the first line represents emissions from wildfires and the second line represents emissions from prescribed burns. If the emissions are coming from a wildfire, then the prescribed fire emissions rate will be set to zero. If the emissions are coming from a prescribed burn, then the wildfire emissions rate will be set to zero. This setup allows us to model wildfire and prescribed burn emission in the same model run, and label particles of each type in the out.

I think we need to make to the code is to account for the fact that the CONTROL file needs to pull only every unique location, not every location listed in the EMITIMES, or else we would end up with duplicates.

@brunj7 brunj7 self-assigned this Jul 28, 2021
@brunj7 brunj7 added the enhancement New feature or request label Jul 28, 2021
@brunj7
Copy link
Member Author

brunj7 commented Jul 28, 2021

The new parametrization required to:

  • split the template files into more chunks to allow that insertion of the starting date/time
  • Modifying the emitimes_read() function (limited changes)
  • Modifying the create_control() function more substantially to handle the 4 templates and various insertions
  • I also move the lat/long selection from the Rmd to the function

I could reproduce the new CONTROL file that Claire had shared. I was not sure where the files with two pollutants are located, so I emailed Claire asking her to do more further testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant