Simplify optional member services and their checkboxes

[raimom]

There's unnecessary complexity with the optional member serivces and their checkboxes in the member application form.
The following:

Jäsenpalvelut
[] Vuosimaksu, 30€ / vuosi
[] Tilankäyttöoikeus, 40€ (10€ min) / kuukausi
Valitse, jos haluat ympärivuorokautisen pääsyn

The two check boxes are probably two too many options in at least 80% or maybe even more than 90% of the new member application cases. It is probable that practically all of the new member applications want the access so it should be default.

The suggestion is to remove the check boxes and set the access fee variable on and create the reference number as default.

[braaar]

Could it be useful to let this form be configurable via the admin panel in some way? Since #433 that is quite easy to set up

[Sandplum]

Additional information:

this is the screen that the applicant sees -->

---

'

---

The list of member services is not translated, being autogenerated from the data of all the member service names.




The help text "Valitse, jos haluat ympärivuorokautisen pääsyn" (also not translated) follows at the bottom of the autogenerated list. The text is intended to explain the TKO, but since it follows at the end of the list, it is not obvious to the applicant that it is related to TKO and not whatever is the last service in the list.




The vuosimaksu choice can be "hidden" by an admin by marking it in the settings for member services. That might make the TKO choice less "optional" to the applicant, if the applicant is required to "You must select at least one service", so this needs to be addressed.

---

'

---

[Sandplum]

Possible solutions:

Add a field to the Django memberservice form to assign (optional) help text to every member service. Add it to the helper in forms.py to display the associated help text with each subscription option on the www application page. Maybe hide the help text if blank or turned off in Django?

Add an option to pre-select a subscription, such as vuosimaksu, if the association requires every applicant to have that subscription as a minimum. Restrict the "required" error message if vuosimaksu is selected and applicant makes no additional selections. The pre-selected option could also be mandatory (applicatant is unable to deselect).

[olmari]

The best solution would be (more) proper UI for registration form, ofcourse it needs still to know some metadata that exists for what to show and when... More dynamic one would be fun... But alas, currently reg-form just lists all the "user subscribeable" services in the selection...