Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sound effect mute shortcut #155

Open
Narninian opened this issue Apr 17, 2024 · 3 comments
Open

Sound effect mute shortcut #155

Narninian opened this issue Apr 17, 2024 · 3 comments
Labels
feature New feature or request

Comments

@Narninian
Copy link

As the app is currently functioning - when you hit the mute button it doesn't mute all Audio. Specifically the sound effects still happen which need to separately toggled off. This is frustrating, particularly as a spectator, as the reason to mute is I don't want audio - not some audio. You can go into settings and separately lower volume of the sounds effects, but there is no visual indicator those have been muted and its easy to forget to turn that volume back up leading to frustrated storytellers when I dont know their pings after I've unmuted.

Describe the solution you'd like
Ideally one of three solutions

  1. Have the Mute button actually mute all audio.
  2. Have an additional 'Global Mute' Button
  3. Have a setting for whether the mute button also mutes sound effects.
@Narninian Narninian added the feature New feature or request label Apr 17, 2024
@bra1n
Copy link
Member

bra1n commented Apr 19, 2024

Hey Narninian,

thanks for the suggestion! I'm not sure option 1 would be ideal, since I believe that many of our users actually prefer to be abl to only mute the chat, rather than the whole app. I think option 2 would be best, basically adding a shortcut (and a main menu entry) for sound effect muting. Option 3 would also be possible, but seems like the more complicated option to me. So I'd go with 2.

@bra1n bra1n self-assigned this Apr 19, 2024
@bra1n bra1n moved this from Backlog to Planned in Blood on the Clocktower App Apr 19, 2024
@bra1n bra1n changed the title Global Mute Sound effect mute shortcut Apr 19, 2024
@bra1n bra1n removed their assignment Apr 19, 2024
@VinylVault
Copy link

I think option 3 would the better way of doing it, stick it in the settings maybe as "Global Mute"
On: No SFx
Off: Only Voice Chat

But also we should be aware that some STs may use this in replacement for Hells Librarian, or in conjunction with it

@bra1n
Copy link
Member

bra1n commented Apr 27, 2024

But also we should be aware that some STs may use this in replacement for Hells Librarian, or in conjunction with it

Any volume level changes would be purely client side and not applied for other users in the session.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Development

No branches or pull requests

3 participants