-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Add support for write.data.path
and write.metadata.path
#1492
Comments
Sorry I raised a duplicated one by accident, which is closed now. Can I work on this feature? |
@jiakai-li assigned to you! |
BTW this is how java side is done https://grep.app/search?q=WRITE_DATA_LOCATION&filter[repo][0]=apache/iceberg&filter[path][0]=core/src/ |
Thanks for volunteering @jiakai-li! Happy to review the |
Hey @smaheshwar-pltr , thanks for the offer! I hadn’t realized this feature is closely tied to LocationProvider. After looking into it, I think it could fit well with the changes you’re already working on. Would you like to handle it as part of your update, or would you prefer I continue working on it? |
Good suggestion @jiakai-li - I expressed my thoughts here: #1452 (comment). I'd prefer to keep #1452 as just what's needed to address the issue linked on it because:
I'd prefer that both of these new write options be tackled together in a follow-up PR, that closes this issue - let me know how this sounds to you. |
Sure, that makes sense to me, thank you @smaheshwar-pltr , :-) |
#1452 is merged, we can now work on adding support for the above |
Feature Request / Improvement
In the write properties section
#1452 adds support for LocationProvider #1452 (comment)
Similar issue, #161
The text was updated successfully, but these errors were encountered: