Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove workaround for TimestampNTZType in TestHelpers #11945

Open
1 of 3 tasks
nastra opened this issue Jan 10, 2025 · 0 comments
Open
1 of 3 tasks

Remove workaround for TimestampNTZType in TestHelpers #11945

nastra opened this issue Jan 10, 2025 · 0 comments
Labels
bug Something isn't working not-stale

Comments

@nastra
Copy link
Contributor

nastra commented Jan 10, 2025

Apache Iceberg version

1.7.1 (latest release)

Query engine

Spark

Please describe the bug 🐞

Once https://issues.apache.org/jira/browse/SPARK-50624 has been released, the workaround in

// ColumnarRow.get doesn't support TimestampNTZType, causing tests to fail. the representation
// is identical to TimestampType so this uses that type to validate.
if (type instanceof TimestampNTZType) {
type = TimestampType$.MODULE$;
}
can be removed

Willingness to contribute

  • I can contribute a fix for this bug independently
  • I would be willing to contribute a fix for this bug with guidance from the Iceberg community
  • I cannot contribute a fix for this bug at this time
@nastra nastra added bug Something isn't working not-stale labels Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working not-stale
Projects
None yet
Development

No branches or pull requests

1 participant