Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Azure Managed Identity for Azure Event Hubs event-source #3207

Open
pauldotyu opened this issue Jul 16, 2024 · 1 comment · May be fixed by #3434
Open

Support Azure Managed Identity for Azure Event Hubs event-source #3207

pauldotyu opened this issue Jul 16, 2024 · 1 comment · May be fixed by #3434
Labels
enhancement New feature or request

Comments

@pauldotyu
Copy link

pauldotyu commented Jul 16, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.
Azure EventHubs event source currently supports key-based authentication only. When deploying Azure EventHubs with local authentication disabled, which is a security best practice, there is no way to configure the event source to use Microsoft Entra Workload Identity. This event source should support service principal authentication similar to Azure ServiceBus event source

Describe the solution you'd like
The Azure EventHubs event source should be refactored to work similarly to Azure ServiceBus event source.

Describe alternatives you've considered
Alternative is to leave as-is and not support workload identity.

Additional context
As part of this refactoring, the SDK for event hubs needs to be updated from deprecated azure-event-hubs-go to current azure-sdk-for-go/sdk/messaging/azeventhubs.

Also wanted to note that I'd be happy to contribute a PR for this.

Message from the maintainers:

If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.
@pauldotyu pauldotyu added the enhancement New feature or request label Jul 16, 2024
@pauldotyu
Copy link
Author

pauldotyu commented Jan 16, 2025 •
edited
Loading

Digging into this now and I see that the start.go file for Azure Event Hub uses https://pkg.go.dev/github.com/Azure/azure-event-hubs-go/v3 which is now deprecated in favor of https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/sdk/messaging/azeventhubs. I'll look to implement the newer package which will make the workload identity implementation easier.

@pauldotyu pauldotyu linked a pull request Jan 16, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add workload identity support to azure event hub eventsource pauldotyu/argo-events
1 participant
@pauldotyu