Support streaming output for more types #380
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We add support for `Magnitude`, `Constant`, and `SymbolFor`. In the test, including `speed_of_light.hh` felt easier than defining a new version of the speed of light constant. This brought in the authoritative definition of `Seconds`, so we deleted our ad hoc definition. In general, it would be nice to clearly articulate a policy as to which header files we want to let ourselves use in which test files: there's a tension between convenience, and keeping dependencies clean. But this is fine for now. Fixes #378.
chiphogg
added
the
release notes: ✨ lib (enhancement)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add support for
Magnitude,Constant, andSymbolFor.In the test, including
speed_of_light.hhfelt easier than defining anew version of the speed of light constant. This brought in the
authoritative definition of
Seconds, so we deleted our ad hocdefinition. In general, it would be nice to clearly articulate a policy
as to which header files we want to let ourselves use in which test
files: there's a tension between convenience, and keeping dependencies
clean. But this is fine for now.
Fixes #378.