Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove lazy_static and once_cell dependencies #3148

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nyurik
Copy link

@nyurik nyurik commented Jan 20, 2025

Description

LazyLock has been available since 1.80 which is less than MSRV

@github-actions github-actions bot added binding/python Issues for the Python package binding/rust Issues for the Rust crate labels Jan 20, 2025
@nyurik nyurik force-pushed the remove-lazy-static branch from b1accc7 to 9e86284 Compare January 20, 2025 23:34
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 89.16667% with 26 lines in your changes missing coverage. Please review.

Project coverage is 72.17%. Comparing base (a73d646) to head (9e86284).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/kernel/models/fields.rs 80.64% 12 Missing ⚠️
crates/aws/src/constants.rs 0.00% 8 Missing ⚠️
crates/azure/src/config.rs 0.00% 3 Missing ⚠️
crates/gcp/src/config.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3148      +/-   ##
==========================================
+ Coverage   71.88%   72.17%   +0.28%     
==========================================
  Files         134      137       +3     
  Lines       43479    44082     +603     
  Branches    43479    44082     +603     
==========================================
+ Hits        31257    31817     +560     
- Misses      10201    10239      +38     
- Partials     2021     2026       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

LazyLock has been available since 1.80 which is less than MSRV

Signed-off-by: Yuri Astrakhan <YuriAstrakhan@gmail.com>
@nyurik nyurik force-pushed the remove-lazy-static branch from 9e86284 to 561c52e Compare January 21, 2025 00:10
@nyurik nyurik changed the title chore: remove lazy_static dep in favor of LazyLock chore: remove lazy_static and once_cell dependencies Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/python Issues for the Python package binding/rust Issues for the Rust crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant