shell completion tests fail with EmptyHost

[thkoch2001]

Setup

My .env:

PG_DATABASE_URL=postgresql://thk@/diesel_test?host=/var/run/postgresql
PG_EXAMPLE_DATABASE_URL=postgresql://thk@/diesel_example?host=/var/run/postgresql

Versions

• Diesel: master branch on January 4th 2024, commit id: 977a2b0

Problem Description

I ran cargo xtask run-tests --no-doc-tests postgres and all 3 tests in diesel_cli::tests completion_generation failed at

diesel_cli/tests/support/project_builder.rs:111:51:
called `Result::unwrap()` on an `Err` value: EmptyHost

Cause

line 111 is:

    let mut db_url = url::Url::parse(&var_os).unwrap();

The url crate is used to parse a postgres connection url and I specified the host as a parameter.

I can just changed my .env to:

PG_DATABASE_URL=postgresql://thk@%2Fvar%2Frun%2Fpostgresql/diesel_test
PG_EXAMPLE_DATABASE_URL=postgresql://thk@%2Fvar%2Frun%2Fpostgresql/diesel_example

And now the shell completion tests worked.

Proposal

Either fix the test code or add a comment in .env.sample about this issue.

[weiznich]

Thanks for reporting. Given that the the relevant line is only calling the URL crate and that seems not to be able to handle this specific URL format it seems to be easier to put a comment about this into the .env.sample file. It would be great to receive a PR for this.