Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: setup now sets migrations dir as relative path when possible #4439

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: setup now sets migrations dir as relative path when possible #4439

wants to merge 2 commits into from
+36 −1

Conversation

the-solid-box
Copy link

fixes #4436

@the-solid-box
Copy link
Author

I do not know where macos differs when it comes to the second test I have included. Since I do not have the means to run tests on macos, and I do not wish to pollute this PR with hypothese-commits on what could be the fix, I'd appreciate if someone can enlighten me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setup should not use an absolute path to set the migrations_directory 'dir' field of diesel.toml
1 participant
@the-solid-box