Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/Remove Todos in the 'Codebase Best Practices' page #393

Open
MacMacky opened this issue Oct 7, 2024 · 4 comments · May be fixed by #552
Open

Update/Remove Todos in the 'Codebase Best Practices' page #393

MacMacky opened this issue Oct 7, 2024 · 4 comments · May be fixed by #552
Labels
help wanted Extra attention is needed type: bug Something isn't working

Comments

@MacMacky
Copy link
Contributor

MacMacky commented Oct 7, 2024

Describe the issue
In the https://contribute.freecodecamp.org/codebase-best-practices/ page, there are some todos/comments that should be remove/updated

Image
Image

I think for the 1st image, we're doing it sort of, not sure about the second image, since we don't have a store

@raisedadead raisedadead added the type: bug Something isn't working label Oct 22, 2024
@shyam-cmd
Copy link

in first image, it looks like we are already implementing the practice mentioned.
For the second image, since we do not have a store, I will remove this todo comment as it is not applicable.

@ilenia-magoni
Copy link
Contributor

ilenia-magoni commented Jan 18, 2025

those would have been invisible comments, they worked with the previous build, now the review of the various pages is a WIP

the ideal would be to check if the comments still need to be there, or if they are actionable. If they are actionable, do the thing and remove them, if they are no longer relevant remove them.

@ilenia-magoni ilenia-magoni added the help wanted Extra attention is needed label Jan 18, 2025
@shyam-cmd
Copy link

OK, If the comments are no longer relevant, I will simply remove them.

@shyam-cmd shyam-cmd linked a pull request Jan 18, 2025 that will close this issue
2 tasks
@ilenia-magoni
Copy link
Contributor

@shyam-cmd I don't know if they are not relevant, you would need to check the status of the things mentioned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed type: bug Something isn't working
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

4 participants