Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reapply the two approvals requirement for PRs #10440

Open
timflannagan opened this issue Jan 13, 2025 · 1 comment
Open

Reapply the two approvals requirement for PRs #10440

timflannagan opened this issue Jan 13, 2025 · 1 comment

Comments

@timflannagan
Copy link
Member

Do you have a suggestion for code improvement or tracking existing technical debt? Please describe.

Right now the repository requires two approvals from folks with write or admin access to the repository. This requirement was present before the gloo repository was transitioned to this new organization.

Describe the solution you'd like

As we continue to bootstrap this repository, being able to relax this requirement to a single approval can make it easier to iterate on this new project. We can introduce more guardrails over time once we reach a more stable status.

Additional Context

N/A.

@lgadban
Copy link
Contributor

lgadban commented Jan 16, 2025

This was done, let's revert it back to 2 soon!
Also see: CODEOWNERS

@lgadban lgadban changed the title Relax the two approvals requirement for PRs Reapply the two approvals requirement for PRs Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

2 participants