Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add example of validating admission webhook #49

Open
pohly opened this issue Jun 13, 2024 · 3 comments · May be fixed by #75
Open

add example of validating admission webhook #49

pohly opened this issue Jun 13, 2024 · 3 comments · May be fixed by #75
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@pohly
Copy link
Contributor

pohly commented Jun 13, 2024

In Kubernetes 1.31, custom configuration parameters will get embedded inside ResourceClaim and ResourceClaimTemplate. They are clearly marked as belonging to a certain DRA driver, so an admission webhook provided together with that driver can check those configuration parameters early instead much later in the NodePrepareResources call.

While writing a webhook is documented elsewhere, having an example that is specific to these types is still valuable.

@pohly
Copy link
Contributor Author

pohly commented Jun 13, 2024

/help

@k8s-ci-robot
Copy link
Contributor

@pohly:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jun 13, 2024
@johnbelamaric johnbelamaric moved this from 🆕 New to 🔖 Ready in SIG Node: Dynamic Resource Allocation Dec 10, 2024
@nojnhuh
Copy link
Contributor

nojnhuh commented Jan 14, 2025

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants