Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable local authentication between Airlock Processor and Azure Service Bus in Function Binding #4277

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

guybartal
Copy link
Collaborator

Resolves #4259

What is being addressed

Customers may want to disable local auth between azure functions and
service bus queues, this PR sets the requiered environment variables for Azure Function bindings in Airlock Processor module.

How is this addressed

@guybartal
Copy link
Collaborator Author

/help

Copy link

🤖 pr-bot 🤖

Hello!

You can use the following commands:
    /test - build, deploy and run smoke tests on a PR
    /test-extended - build, deploy and run smoke & extended tests on a PR
    /test-extended-aad - build, deploy and run smoke & extended AAD tests on a PR
    /test-shared-services - test the deployment of shared services on a PR build
    /test-force-approve - force approval of the PR tests (i.e. skip the deployment checks)
    /test-destroy-env - delete the validation environment for a PR (e.g. to enable testing a deployment from a clean start after previous tests)
    /help - show this help

(in response to this comment from @guybartal)

Copy link

github-actions bot commented Jan 19, 2025

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 7ad89d4.

♻️ This comment has been updated with latest results.

@guybartal guybartal changed the title Guybartal/airlock-disable-local-auth-for-sb Disable local authentication between Airlock Processor and Azure Service Bus in Function Binding Jan 19, 2025
@guybartal
Copy link
Collaborator Author

/test

Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/12854924727 (with refid 07c0773e)

(in response to this comment from @guybartal)

Comment on lines +72 to +76
"SB_CONNECTION_STRING" = var.airlock_servicebus.default_primary_connection_string
"SB_CONNECTION_STRING__tenantId" = azurerm_user_assigned_identity.airlock_id.tenant_id
"SB_CONNECTION_STRING__clientId" = azurerm_user_assigned_identity.airlock_id.client_id
"SB_CONNECTION_STRING__credential" = "managedidentity"
"SB_CONNECTION_STRING__fullyQualifiedNamespace" = var.airlock_servicebus_fqdn
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider doing this like I have in the EventGrid PR.

"id": "Microsoft.Azure.Functions.ExtensionBundle",
"version": "[4.0.0, 5.0.0)"
"version": "[4.*, 5.0.0)"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you have confirmed that the current versions we use don't support this?

@@ -62,6 +62,9 @@ variable "airlock_servicebus" {
default_primary_connection_string = string
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried to add the endpoint property here and checking if it will get populated automatically?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable local authentication in ServiceBus
2 participants