-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable local authentication between Airlock Processor and Azure Service Bus in Function Binding #4277
base: main
Are you sure you want to change the base?
Conversation
…ween airlock and servicebus queue
/help |
🤖 pr-bot 🤖 Hello! You can use the following commands: (in response to this comment from @guybartal) |
Unit Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 7ad89d4. ♻️ This comment has been updated with latest results. |
/test |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/12854924727 (with refid (in response to this comment from @guybartal) |
"SB_CONNECTION_STRING" = var.airlock_servicebus.default_primary_connection_string | ||
"SB_CONNECTION_STRING__tenantId" = azurerm_user_assigned_identity.airlock_id.tenant_id | ||
"SB_CONNECTION_STRING__clientId" = azurerm_user_assigned_identity.airlock_id.client_id | ||
"SB_CONNECTION_STRING__credential" = "managedidentity" | ||
"SB_CONNECTION_STRING__fullyQualifiedNamespace" = var.airlock_servicebus_fqdn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider doing this like I have in the EventGrid PR.
"id": "Microsoft.Azure.Functions.ExtensionBundle", | ||
"version": "[4.0.0, 5.0.0)" | ||
"version": "[4.*, 5.0.0)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So you have confirmed that the current versions we use don't support this?
@@ -62,6 +62,9 @@ variable "airlock_servicebus" { | |||
default_primary_connection_string = string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tried to add the endpoint
property here and checking if it will get populated automatically?
Resolves #4259
What is being addressed
Customers may want to disable local auth between azure functions and
service bus queues, this PR sets the requiered environment variables for Azure Function bindings in Airlock Processor module.
How is this addressed