You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
using the CMake of third-party libraries (like fmt and Eigen) instead of just copying them and manually adding them to -I via include_directories() and similar
Summary
Opening this tracking issue to collect links and discussion for proposed work to improve LightGBM's CMake configuration.
LightGBM is on a very new version of CMake (3.28), thanks to #6550 ... let's take advantage of that newer version's powerful features.
Motivation
find_package(lightgbm)
"just work" for projects depending on LightGBMDescription
Non-exhaustive list of potential changes to explore:
VERSION
on the projectVERSION
andSOVERSION
on the shared libraryinclude_directories()
->target_include_directories()
add_definitions()
->target_compile_definitions()
CMakeLists.txt
CMakeLists.txt
intests/cpp_tests
R CMD INSTALL R-package/
orpip install python-package/
"just work"fmt
andEigen
) instead of just copying them and manually adding them to-I
viainclude_directories()
and similarReferences
Some references informing this:
Notes for Readers
Please comment with other ideas and I'd be happy to add them to the list here if we agree.
The text was updated successfully, but these errors were encountered: