Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check perf results is too sensitive - non-regression noise exceeds 2 sigma variation #4115

Open
Alan-Jowett opened this issue Jan 2, 2025 · 1 comment
Assignees
Labels
P3 tests triaged Discussed in a triage meeting
Milestone

Comments

@Alan-Jowett
Copy link
Member

The script uses the default value for max_sigma, which is 2. Consider passing a higher threshold to avoid false positives on regressions.

psql -f ./check_perf_results.sql -v platform='${{inputs.platform}}' --csv > ${{github.workspace}}/results/regression_results.csv

https://github.com/microsoft/bpf_performance/blob/492e048521959aa0e679e8779d8cdf743da0a9a1/scripts/check_perf_results.sql#L24

@shankarseal shankarseal added triaged Discussed in a triage meeting tests labels Jan 6, 2025
@shankarseal
Copy link
Collaborator

We probably should use a more sophisticated statistical tool than 2xsigma.
Possible candidates

  • Kolmogorov-Smirnov
  • Run multiple times and pick lowest value
  • mean over last 3 runs and then check if it breaches 2 sigma
  • Use 3 sigma
  • Use a threshold (% of mean). 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 tests triaged Discussed in a triage meeting
Projects
None yet
Development

No branches or pull requests

3 participants