Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advice #1760

Open
chen1234234 opened this issue Dec 21, 2024 · 3 comments · May be fixed by #1762
Open

Advice #1760

chen1234234 opened this issue Dec 21, 2024 · 3 comments · May be fixed by #1762

Comments

@chen1234234
Copy link

chen1234234 commented Dec 21, 2024

I rhink @sam951013 is contributor on VS Code language Pack(Chinese Traditional).We should add him to this contributor list.
https://github.com/microsoft/vscode-loc/blob/main/i18n/vscode-language-pack-zh-hant/README.md

@csigs
Copy link
Member

csigs commented Dec 21, 2024

Thank you for your feedback. We will review the issue (ICX ADO Tracking Reference: 1020153).

@sam951013
Copy link
Contributor

I am happy to heared that.

chen1234234 added a commit to chen1234234/vscode-loc that referenced this issue Dec 28, 2024
@chen1234234 chen1234234 linked a pull request Dec 28, 2024 that will close this issue
@crsuzukimsft
Copy link

@TylerLeonhardt fyi on this. Not sure if you need to grant any permissions here.

@TylerLeonhardt TylerLeonhardt linked a pull request Jan 14, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants