Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug with UI and expression highlighting #11484

Open
barn4k opened this issue Oct 31, 2024 · 2 comments · May be fixed by #12633
Open

Bug with UI and expression highlighting #11484

barn4k opened this issue Oct 31, 2024 · 2 comments · May be fixed by #12633
Labels
in linear Issue or PR has been created in Linear for internal review

Comments

@barn4k
Copy link

barn4k commented Oct 31, 2024

Bug Description

If I have an expression with symbol 🟢, then the highlight will be completely broken

With the green symbol it's get broken
image
but the result is fine
image

with red one everything is fine
image

To Reproduce

the workflow

{
  "meta": {
    "instanceId": "ea8ccd7cb9d9fc233a4683c7569b952c9669ba9d3ba1459d89a9944d357fa5b3"
  },
  "nodes": [
    {
      "parameters": {},
      "id": "994aa420-021b-488c-8834-588a9187204f",
      "name": "When clicking ‘Test workflow’",
      "type": "n8n-nodes-base.manualTrigger",
      "position": [
        820,
        380
      ],
      "typeVersion": 1
    },
    {
      "parameters": {
        "assignments": {
          "assignments": [
            {
              "id": "91b1a47a-2c61-4001-8a27-0cbbcae58448",
              "name": "test",
              "value": "={{ 1 === 1 ? \"🟢\" : \"🔴\" }}",
              "type": "string"
            }
          ]
        },
        "options": {}
      },
      "id": "bbb5a27c-f706-495c-be7b-cfc53e8c8de9",
      "name": "Edit Fields",
      "type": "n8n-nodes-base.set",
      "typeVersion": 3.4,
      "position": [
        1040,
        380
      ]
    }
  ],
  "connections": {
    "When clicking ‘Test workflow’": {
      "main": [
        [
          {
            "node": "Edit Fields",
            "type": "main",
            "index": 0
          }
        ]
      ]
    }
  },
  "pinData": {}
}

or the test expression
{{ 1 === 1 ? "🟢" : "🔴" }}

Expected behavior

The expression is properly highlighted

Operating System

cloud

n8n Version

1.60.1

Node.js Version

cloud

Database

SQLite (default)

Execution mode

main (default)
@Joffcom
Copy link
Member

Joffcom commented Oct 31, 2024

Hey @barn4k,

We have created an internal ticket to look into this which we will be tracking as "GHC-370"

@Joffcom Joffcom added the in linear Issue or PR has been created in Linear for internal review label Oct 31, 2024
@Joffcom
Copy link
Member

Joffcom commented Oct 31, 2024

Hey @barn4k,

Thanks for the report, I am 90% sure this issue already exists somewhere. I will see if I can find it.

@jeanpaul jeanpaul linked a pull request Jan 16, 2025 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in linear Issue or PR has been created in Linear for internal review
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(editor): Add unicode code points to expression language for emoji n8n-io/n8n
2 participants
@Joffcom @barn4k