Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chat regressions on master related to list spacing and emoji span #2512

Closed
taoeffect opened this issue Jan 17, 2025 · 0 comments · Fixed by #2521
Closed

Chat regressions on master related to list spacing and emoji span #2512

taoeffect opened this issue Jan 17, 2025 · 0 comments · Fixed by #2521
Assignees
@SebinSong
Labels
App:Frontend Kind:Bug Note:UI/UX Priority:High

Comments

@taoeffect
Copy link
Member

taoeffect commented Jan 17, 2025 •
edited
Loading

Problem

Testing loading the GIG group locally over localhost:3000 in Firefox (EDIT: and Safari too!) on master, I see this:

Image
Image

Multiple issues:

  1. The spacing on lists, both ordered and unordered, is completely wrong.
  2. For some reason numbers are now wrapped in <span class="chat-emoji">, wherever they are, even in URLs

Solution

Restore previous behavior.
@taoeffect taoeffect changed the title Firefox chat weirdness on master Chat regressions on master related to list spacing and emoji span Jan 17, 2025
@SebinSong SebinSong mentioned this issue Jan 18, 2025
Merged
taoeffect pushed a commit that referenced this issue Jan 20, 2025
@SebinSong
#2512 - Fix a couple of chat regressions (#2521)
cb101e5 
* fix the emoji related issue

* fix the wrong line-break errors

* fix the code-block bug

* enhance/simplify the logic to keep multiple line-breaks in chat

* fix some linter errs

* fix additional bugs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SebinSong SebinSong

Labels
App:Frontend Kind:Bug Note:UI/UX Priority:High
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#2512 - Fix a couple of chat regressions okTurtles/group-income
2 participants
@taoeffect @SebinSong