Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not allow spaces in external billing #13081

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Do not allow spaces in external billing #13081

wants to merge 1 commit into from
+10 −0

Conversation

pacodelaluna
Copy link
Contributor

What? Why?

I forgot to add a basic validation on the external_billing_id field on my last PR.

What should we test?

  • Visit an enterprise page as superadmin
  • Try to change the External Billing Id field on Primary Details tab
  • Verify that adding a space on the value is failing the form submission

Release notes

  • Do not allow spaces in external billing id on enterprises

Changelog Category (reviewers may add a label for the release notes):

  • User facing changes
  • API changes (V0, V1, DFC or Webhook)
  • Technical changes only
  • Feature toggled

@pacodelaluna pacodelaluna force-pushed the do-not-allow-spaces-in-external-billing-id branch from dbb2515 to 39825a9 Compare January 19, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pacodelaluna pacodelaluna

Labels
None yet
Projects
OFN Delivery board
Status: All the things 💤
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't allow spaces in external billing id
1 participant
@pacodelaluna