Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enterprise Fees page] "true" appearing as first/default option #13080

Open
filipefurtad0 opened this issue Jan 16, 2025 · 1 comment
Open

[Enterprise Fees page] "true" appearing as first/default option #13080

filipefurtad0 opened this issue Jan 16, 2025 · 1 comment
Labels
bug-s3 The bug is stopping a critical or non-critical feature but there is a usable workaround. regression Tagging any identified regressions

Comments

@filipefurtad0
Copy link
Contributor

Description

On the enterprise fees page, an unknown string appears as the first option, when selecting a tax category. This does not relate to any of the setup tax categories and its actual functionality is unknown.

This is also a missing translation.

Expected Behavior

"true" should not appear on the enterprise fees page, when selecting a tax category (unless there is a tax category set with that designation).

Actual Behaviour

"true" appears on the enterprise fees page, when selecting a tax category (although no tax category is set with that designation).

Steps to Reproduce

  1. Log in as an enterprise manager
  2. Visit /admin/enterprise_fees
  3. Notice the the "true" value as default for new enterprise fees, on the Tax Category column

Animated Gif/Screenshot

Image

Workaround

Selecting other options, other than this "true" option.

Severity

As a missing translation it would usually be considered an bug-s3; I'd say this might have significant impact, as it is the default value when creating new fees, and easy to go unnoticed.

Your Environment

  • Version used: v5.0.10 - although unsure when this was introduced.
  • Browser name and version: Firefox 133.0.3
  • Operating System and version (desktop or mobile): Ubuntu 22.04

Possible Fix

@filipefurtad0 filipefurtad0 added bug-s3 The bug is stopping a critical or non-critical feature but there is a usable workaround. regression Tagging any identified regressions labels Jan 16, 2025
@github-project-automation github-project-automation bot moved this to All the things 💤 in OFN Delivery board Jan 16, 2025
@MrBowmanXD
Copy link
Contributor

If we remove include_blank option in the ofn-select from the file index.html.haml we remove the true option from the tax category and it remains blank. ( app/views/admin/enterprise_fees/index.html.haml ) (file path).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-s3 The bug is stopping a critical or non-critical feature but there is a usable workaround. regression Tagging any identified regressions
Projects
Status: All the things 💤
Development

No branches or pull requests

2 participants