fix(python): Add height check to frame-level row indexing when key is int #20778
+23
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcrumiller
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
github-actions
bot
added
fix
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20778 +/- ##
==========================================
- Coverage 79.63% 79.63% -0.01%
==========================================
Files 1568 1568
Lines 222970 222974 +4
Branches 2544 2545 +1
==========================================
+ Hits 177555 177558 +3
- Misses 44831 44832 +1
Partials 584 584 ☔ View full report in Codecov by Sentry. |
mcrumiller
changed the title
mcrumiller
force-pushed
the
df-slice-check
branch
from
e830977 to
588d19a
Compare
|
Need to check negative indexing as well. |
mcrumiller
force-pushed
the
df-slice-check
branch
from
588d19a to
8f7b308
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20775.
The issue is that
df.slice(idx, 1)was being called for a single integer index key, and slices return the empty set instead of raising whenidxis out of bounds. This PR adds a small height check.