Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid and property layer for hexgrid #2433

Open
quaquel opened this issue Oct 30, 2024 · 2 comments
Open

Grid and property layer for hexgrid #2433

quaquel opened this issue Oct 30, 2024 · 2 comments
Labels
bug Release notes label feature Release notes label visualisation

Comments

@quaquel
Copy link
Member

quaquel commented Oct 30, 2024

#2430 adds support for plotting hexgrids. It comes with an optional grid using a patchcollection. This results in some overdrawing of lines wich is less than ideal.

Also, property layers won't display correctly yet because the coordinate systems are different.

The solution to both might be to create a polycollection (as used in matplotlib's hexbin).

@quaquel quaquel added bug Release notes label feature Release notes label visualisation labels Oct 30, 2024
@Sahil-Chhoker
Copy link
Contributor

I am reading this issue now that I have opened a PR(#2609) for the fix of hex-grid overlapping, do you think I should have used PolyCollection instead of LineCollection?
Also I would like to work on the property layer issue as well, any pointers before I start working on that?

@quaquel
Copy link
Member Author

quaquel commented Jan 20, 2025

Not sure. Conceptually, the grid drawing and the property layers drawing can use distinct datastructures. Implementation-wise, they are distinct methods, so it might be easier to merge #2609 first and iterate back to it after addressing the property layer drawing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Release notes label feature Release notes label visualisation
Projects
None yet
Development

No branches or pull requests

2 participants