Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On the OC Setup command proxy didn't use for the versioned url even the proxy has specified #176

Open
developertyrone opened this issue Nov 6, 2020 · 0 comments

Comments

@developertyrone
Copy link

Seems on line 269 - 276 of oc-install.ts didn't use the proxy for versioned url even the proxy option has specified?

It may cause the oc setup to break if the pipeline agent is behind the web proxy.

    if (url) {
      // check if url is valid otherwise take the latest stable oc cli for this version
      const response = await fetch(url, { method: 'HEAD' });
      findURLofLatest = !response.ok;
    }
    if (findURLofLatest) {
      url = InstallHandler.ocBundleURL(version.value, osType, true);
    }

(Although the azure pipeline agent can specify proxy and proxy pass for self host agent as global setting. )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant