Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some extensions need to include .crx files #131

Open
kennynguyeenx opened this issue Jun 10, 2021 · 1 comment · May be fixed by #133
Open

Some extensions need to include .crx files #131

kennynguyeenx opened this issue Jun 10, 2021 · 1 comment · May be fixed by #133
Labels
Milestone

Comments

@kennynguyeenx
Copy link

kennynguyeenx commented Jun 10, 2021

I need to pack one extension which include another .crx files but for now they are ignored in code and we don't have any options to configure for it

For now, I have hard patched the module in node_modules folder but this is not ideal.

https://github.com/oncletom/crx/blob/master/src/index.js#L160

ignore: ["*.pem", ".git", "*.crx"]
=>
ignore: ["*.pem", ".git"]

@thom4parisot
Copy link
Owner

Sorry for lagging and making you wait. And thanks for reporting this issue!

It totally makes sense to me, I’m thinking to make the ignore bit an option.

And maybe in the future to rework the API so the file list becomes a mandatory argument.

If you feel like proposing a fix you’re welcome, otherwise I’ll do it when I get my computer back from repair.

@thom4parisot thom4parisot added this to the v5.1 milestone Aug 24, 2021
@thom4parisot thom4parisot linked a pull request Aug 28, 2021 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants