Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What does the codebase option mean? #74

Open
thomasdavis opened this issue Jan 31, 2018 · 2 comments
Open

What does the codebase option mean? #74

thomasdavis opened this issue Jan 31, 2018 · 2 comments

Comments

@thomasdavis
Copy link

Sorry for naivety but why do I have to link to a .crx file? I though the purpose of this library is to generate one?

@ngyikp
Copy link
Contributor

ngyikp commented Feb 1, 2018

The codebase option is only used for generating the auto-update XML for self-hosted CRX, you can just ignore it if you don't plan to use that function

https://github.com/oncletom/crx/blob/09a074a633e60bc84ef3036ee7f3aa4be71b91aa/src/crx.js#L278-L292

@thom4parisot
Copy link
Owner

@ngyikp answer is a good one, thanks :-)

I realize the README is not that clear about it. @thomasdavis how did you stumble on the codebase option? Let us know if you think of something else which would have avoided you stumbling on this issue :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants