Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Detection Error for vg-play-back component #845

Open
YomeKatsuma opened this issue Jul 22, 2019 · 2 comments · May be fixed by #890
Open

Change Detection Error for vg-play-back component #845

YomeKatsuma opened this issue Jul 22, 2019 · 2 comments · May be fixed by #890

Comments

@YomeKatsuma
Copy link

YomeKatsuma commented Jul 22, 2019 •
edited
Loading

Description

When clicking on the 'play back' (aka read speed), a Change Detection error occurs.

Expected Behavior

No error should occur.

Actual Behavior

An error is rised :

VgPlaybackButton.html:2 ERROR Error: ExpressionChangedAfterItHasBeenCheckedError: Expression has changed after it was checked. Previous value: 'aria-valuetext: 1'. Current value: 'aria-valuetext: 1.5'.
    at viewDebugError (core.js:25491)
    at expressionChangedAfterItHasBeenCheckedError (core.js:25468)
    at checkBindingNoChanges (core.js:25772)
    at checkNoChangesNodeInline (core.js:38548)
    at checkNoChangesNode (core.js:38521)
    at debugCheckNoChangesNode (core.js:39482)
    at debugCheckRenderNodeFn (core.js:39414)
    at Object.eval [as updateRenderer] (VgPlaybackButton.html:2)
    at Object.debugUpdateRenderer [as updateRenderer] (core.js:39399)
    at checkNoChangesView (core.js:38356)

Steps to Reproduce

Just start a video, then, click on the x1 button => the error occurs.
@pankajhartron
Copy link

+1

@vicatcu
Copy link

vicatcu commented Mar 30, 2020

I can confirm this issue is still present with @angular/core@8.2.8 and @videogular2@7.0.1

vicatcu added a commit to vicatcu/videogular2 that referenced this issue Mar 31, 2020
@vicatcu
fix(VgPlaybackButton): Added ChangeDetectorRef and called detectChang…
a56c7da 
…es() in click handler

I injected `public cdr: ChangeDetectorRef` into VgPlaybackButton and called `detectChanges()` as the
last action in the `updatePlaybackSpeed()` method. This fixes videogular#845. I had to make some innocuous
changes to some spec files to get it to build because of compile-time errors when running `npm run
build`.

845
@vicatcu vicatcu linked a pull request Mar 31, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(VgPlaybackButton): Added ChangeDetectorRef and called detectChang… vicatcu/videogular2
3 participants
@vicatcu @YomeKatsuma @pankajhartron