code climate issues

Adobe-Consulting-Services · Jan 3, 2025 · d051472 · d051472
1 parent eaf230c
commit d051472
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/bundle/src/main/java/com/adobe/acs/commons/redirects/servlets/ImportRedirectMapServlet.java b/bundle/src/main/java/com/adobe/acs/commons/redirects/servlets/ImportRedirectMapServlet.java
@@ -161,7 +161,9 @@ void update(Resource root, Collection<Map<String, Object>> xlsRedirects, Map<Str
                 }
                 Resource redirect = getOrCreateRedirect(shard, sourcePath, props, jcrRedirects);
                 log.trace("rule[{}]: {}", count, redirect.getPath());
-                if(count % SHARD_SIZE == 0) resolver.commit();
+                if(count % SHARD_SIZE == 0) {
+                    resolver.commit();
+                }
             }
         } else {
             for (Map<String, Object> props : xlsRedirects) {

diff --git a/.../src/test/java/com/adobe/acs/commons/redirects/servlets/ImportRedirectMapServletTest.java b/.../src/test/java/com/adobe/acs/commons/redirects/servlets/ImportRedirectMapServletTest.java
@@ -482,16 +482,14 @@ private void setupFileUpload(byte[] content, String contentType) throws IOExcept
     }
 
     private byte[] createMockExcelFile() throws IOException {
-        List<RedirectRule> rules = new ArrayList<>();
         RedirectRule rule = spy(new RedirectRule());
         doReturn("/old").when(rule).getSource();
         doReturn("/new").when(rule).getTarget();
         doReturn(301).when(rule).getStatusCode();
         doReturn(null).when(rule).getCreatedBy();
         doReturn(null).when(rule).getModifiedBy();
-        rules.add(rule);
 
-        Workbook wb = export(rules);
+        Workbook wb = export(Collections.singletonList(rule));
 
         ByteArrayOutputStream out = new ByteArrayOutputStream();
         wb.write(out);