Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect Manager: Large-Scale Import Optimization #3504

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

YegorKozlov
Copy link
Contributor

Addresses #3501

Copy link

codecov bot commented Jan 19, 2025

Codecov Report

Attention: Patch coverage is 96.34146% with 3 lines in your changes missing coverage. Please review.

Project coverage is 55.88%. Comparing base (ef4f406) to head (e900f4d).
Report is 58 commits behind head on master.

Files with missing lines Patch % Lines
.../adobe/acs/commons/redirects/models/Redirects.java 83.33% 2 Missing ⚠️
...s/redirects/servlets/ImportRedirectMapServlet.java 97.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3504      +/-   ##
============================================
+ Coverage     55.54%   55.88%   +0.33%     
- Complexity     5582     5639      +57     
============================================
  Files           728      731       +3     
  Lines         29775    29943     +168     
  Branches       3884     3914      +30     
============================================
+ Hits          16540    16733     +193     
+ Misses        11684    11649      -35     
- Partials       1551     1561      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Test Results

 2 970 files  ± 0   2 970 suites  ±0   1h 32m 55s ⏱️ - 1m 0s
 1 895 tests + 5   1 895 ✅ + 5  0 💤 ±0  0 ❌ ±0 
17 055 runs  +45  17 046 ✅ +45  9 💤 ±0  0 ❌ ±0 

Results for commit e900f4d. ± Comparison against base commit 6932178.

This pull request removes 5 and adds 10 tests. Note that renamed tests count towards both.
com.adobe.acs.commons.redirects.servlets.ImportRedirectMapServletTest ‑ testImportMixedExistingAndSpreadsheet
com.adobe.acs.commons.redirects.servlets.ImportRedirectMapServletTest ‑ testUpdate
com.adobe.acs.commons.redirects.servlets.RewriteMapServletTest ‑ test301Selector
com.adobe.acs.commons.redirects.servlets.RewriteMapServletTest ‑ test302Selector
com.adobe.acs.commons.redirects.servlets.RewriteMapServletTest ‑ testGet
com.adobe.acs.commons.redirects.servlets.ImportRedirectMapServletTest ‑ testAuditLogCreation
com.adobe.acs.commons.redirects.servlets.ImportRedirectMapServletTest ‑ testExcelImport
com.adobe.acs.commons.redirects.servlets.ImportRedirectMapServletTest ‑ testImportWithValidation
com.adobe.acs.commons.redirects.servlets.ImportRedirectMapServletTest ‑ testMergeExistingRules
com.adobe.acs.commons.redirects.servlets.ImportRedirectMapServletTest ‑ testReplaceExistingRules
com.adobe.acs.commons.redirects.servlets.ImportRedirectMapServletTest ‑ testShardingLargeImport
com.adobe.acs.commons.redirects.servlets.ImportRedirectMapServletTest ‑ testUpdateExistingRule
com.adobe.acs.commons.redirects.servlets.RewriteMapServletTest ‑ testDoGetWithInvalidStatusCodeSelector
com.adobe.acs.commons.redirects.servlets.RewriteMapServletTest ‑ testDoGetWithNoSelector
com.adobe.acs.commons.redirects.servlets.RewriteMapServletTest ‑ testDoGetWithStatusCodeSelector

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants