refactor(core): use snapshots for interpreter tests

EVMcrispr · Jan 10, 2023 · 64229bb · 64229bb
1 parent 5894bd0
commit 64229bb
Show file tree

Hide file tree

Showing 30 changed files with 7,050 additions and 4,206 deletions.
diff --git a/common/test/src/test-helpers/cas11.ts b/common/test/src/test-helpers/cas11.ts
@@ -33,17 +33,23 @@ import { inspect } from 'util';
 const { CommandExpression } = NodeType;
 const { Between, Equal, Greater } = ComparisonType;
 
+export type ForEachCase<V = any, E = any> = {
+  message?: string;
+  value: V;
+  expected?: E;
+  title: string;
+};
 export type Case = [string, any, string?];
 
 export type InterpreterCase = [Node, any, string?];
 // eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
 export const deepConsoleLog = (thing: any): void =>
   console.log(inspect(thing, false, null, true));
 
-export const runParser = (
+export function runParser(
   parser: Parser<any, string, any>,
   value: string,
-): any => {
+): any {
   const res = withData<any, string, NodeParserState>(parser)(
     createParserState(),
   ).run(value);
@@ -53,7 +59,18 @@ export const runParser = (
   }
 
   return res.result;
-};
+}
+
+export function runParserError(parser: NodeParser, text: string): string {
+  const parserState = createParserState();
+  const res = withData<any, string, NodeParserState>(parser)(parserState).run(
+    text,
+  );
+
+  expect(res.isError, 'error not thrown').to.be.true;
+
+  return (res as Err<string, NodeParserState>).error;
+}
 
 export const runCases = (
   caseOrCases: Case | Case[],

diff --git a/core/evmcrispr/src/parsers/array.ts b/core/evmcrispr/src/parsers/array.ts
@@ -14,7 +14,7 @@ import {
   openingCharParser,
 } from './utils';
 
-export const ARRAY_PARSER_ERROR = 'ArrayParserError';
+const ARRAY_PARSER_ERROR = 'ArrayParserError';
 
 export const arrayExpressionParser: NodeParser<ArrayExpressionNode> =
   recursiveParser(() =>

diff --git a/core/evmcrispr/src/parsers/command.ts b/core/evmcrispr/src/parsers/command.ts
@@ -138,7 +138,7 @@ const commandArgsParser = coroutine(function* () {
   return commandArgOrOpt;
 });
 
-export const COMMAND_PARSER_ERROR = 'CommandParserError';
+const COMMAND_PARSER_ERROR = 'CommandParserError';
 
 export const endOfCommandParser = choice([endLine, lookAhead(endOfInput)]);
 

diff --git a/core/evmcrispr/src/parsers/helper.ts b/core/evmcrispr/src/parsers/helper.ts
@@ -25,7 +25,7 @@ import {
   openingCharParser,
 } from './utils';
 
-export const HELPER_PARSER_ERROR = 'HelperParserError';
+const HELPER_PARSER_ERROR = 'HelperParserError';
 
 const helperNameParser = recursiveParser(() =>
   takeLeft(regex(/^(?!-|\.)[a-zA-Z\-.]+(?<!-|\.)/))(

diff --git a/core/evmcrispr/src/parsers/primaries/identifiers.ts b/core/evmcrispr/src/parsers/primaries/identifiers.ts
@@ -19,9 +19,9 @@ import { NodeType } from '../../types';
 import { buildParserError } from '../../utils/parsers';
 import { createNodeLocation, enclosingLookaheadParser, locate } from '../utils';
 
-export const VARIABLE_PARSER_ERROR = 'VariableParserError';
+const VARIABLE_PARSER_ERROR = 'VariableParserError';
 
-export const PROBABLE_IDENTIFIER_PARSER_ERROR = 'IdentifierParserError';
+const PROBABLE_IDENTIFIER_PARSER_ERROR = 'IdentifierParserError';
 
 export const variableIdentifierParser: EnclosingNodeParser<
   VariableIdentifierNode

diff --git a/core/evmcrispr/src/parsers/primaries/literals/address.ts b/core/evmcrispr/src/parsers/primaries/literals/address.ts
@@ -9,7 +9,7 @@ import {
   locate,
 } from '../../utils';
 
-export const ADDRESS_PARSER_ERROR = 'AddressParserError';
+const ADDRESS_PARSER_ERROR = 'AddressParserError';
 
 export const addressParser: EnclosingNodeParser<AddressLiteralNode> = (
   enclosingParsers = [],

diff --git a/core/evmcrispr/src/parsers/primaries/literals/boolean.ts b/core/evmcrispr/src/parsers/primaries/literals/boolean.ts
@@ -9,7 +9,7 @@ import {
   locate,
 } from '../../utils';
 
-export const BOOLEAN_PARSER_ERROR = 'BooleanParserError';
+const BOOLEAN_PARSER_ERROR = 'BooleanParserError';
 
 export const booleanParser: EnclosingNodeParser<BooleanLiteralNode> = (
   enclosingParsers = [],

diff --git a/core/evmcrispr/src/parsers/primaries/literals/hexadecimal.ts b/core/evmcrispr/src/parsers/primaries/literals/hexadecimal.ts
@@ -9,7 +9,7 @@ import {
   locate,
 } from '../../utils';
 
-export const HEXADECIMAL_PARSER_ERROR = 'HexadecimalParserError';
+const HEXADECIMAL_PARSER_ERROR = 'HexadecimalParserError';
 
 export const hexadecimalParser: EnclosingNodeParser<BytesLiteralNode> = (
   enclosingParsers = [],

diff --git a/core/evmcrispr/src/parsers/primaries/literals/string.ts b/core/evmcrispr/src/parsers/primaries/literals/string.ts
@@ -9,7 +9,7 @@ import {
   locate,
 } from '../../utils';
 
-export const STRING_PARSER_ERROR = 'StringParserError';
+const STRING_PARSER_ERROR = 'StringParserError';
 
 export const stringParser: EnclosingNodeParser<StringLiteralNode> = (
   enclosingParsers = [],