expose renderTypingIndicator and handleOnScroll which are already pas… #2565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoodleOfDeath
commented
Dec 7, 2024
| @@ -66,7 +66,7 @@ import { useSafeAreaInsets } from 'react-native-safe-area-context' | |||
|
|
|||
| dayjs.extend(localizedFormat) | |||
|
|
|||
| export interface GiftedChatProps<TMessage extends IMessage = IMessage> { | |||
| export interface GiftedChatProps<TMessage extends IMessage = IMessage> extends Partial<Omit<MessageContainer<TMessage>, 'scrollToBottom'>> { | |||
There was a problem hiding this comment.
had to omit scrollToBottom because of the name collision.. don't want to add a breaking change by renaming this
NoodleOfDeath
commented
Dec 7, 2024
| @@ -148,6 +150,8 @@ export default class MessageContainer< | |||
| } | |||
|
|
|||
| renderTypingIndicator = () => { | |||
| if (this.props.renderTypingIndicator) | |||
| return this.props.renderTypingIndicator() | |||
There was a problem hiding this comment.
exposes renderTypingIndicator to devs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
address the need for this patch
These properties are already passed to the underlying
MessageContainercomponent, so might as well expose them to the developer