fix: fuels dev hangs after compilation errors

.changeset/silly-pianos-fry.md

@@ -0,0 +1,5 @@
+---
+"fuels": patch
+---
+
+fix: `fuels dev` hangs after compilation errors

packages/fuels/src/bin.ts

@@ -1,12 +1,7 @@
 import { error } from './cli/utils/logger';
 import { run } from './run';
 
-try {
-  run(process.argv).catch((x) => {
-    // eslint-disable-next-line no-console
-    console.log(x);
-  });
-} catch (err: unknown) {
+run(process.argv).catch((err) => {
   error((err as Error)?.message || err);
   process.exit(1);
-}
+});

packages/fuels/src/cli/commands/build/forcHandlers.ts

@@ -6,8 +6,7 @@ type OnErrorFn = (reason?: number | Error) => void;
 export const onForcExit =
   (onResultFn: OnResultFn, onErrorFn: OnErrorFn) => (code: number | null) => {
     if (code) {
-      onErrorFn(code);
-      //  process.exit()?
+      onErrorFn(new Error(`forc exited with error code ${code}`));
     } else {
       onResultFn();
     }

packages/fuels/src/cli/commands/dev/index.test.ts

@@ -35,7 +35,7 @@ describe('dev', () => {
 
     const withConfigErrorHandler = vi
       .spyOn(withConfigMod, 'withConfigErrorHandler')
-      .mockReturnValue(Promise.resolve());
+      .mockReturnValue(undefined as never);
 
     const loadConfig = vi
       .spyOn(loadConfigMod, 'loadConfig')

packages/fuels/src/cli/commands/dev/index.ts

@@ -53,7 +53,7 @@ export const configFileChanged = (state: DevState) => async (_event: string, pat
     // eslint-disable-next-line @typescript-eslint/no-use-before-define
     await dev(await loadConfig(state.config.basePath));
   } catch (err: unknown) {
-    await withConfigErrorHandler(<Error>err, state.config);
+    withConfigErrorHandler(<Error>err, state.config);
   }
 };
 

packages/fuels/src/cli/commands/node/index.test.ts

@@ -25,7 +25,7 @@ describe('node', () => {
 
     const withConfigErrorHandler = vi
       .spyOn(withConfigMod, 'withConfigErrorHandler')
-      .mockReturnValue(Promise.resolve());
+      .mockReturnValue(undefined as never);
 
     const loadConfig = vi
       .spyOn(loadConfigMod, 'loadConfig')

packages/fuels/src/cli/commands/withConfig.test.ts

@@ -69,7 +69,7 @@ describe('withConfig', () => {
       shouldErrorOnDeploy: true,
     });
 
-    await withConfig(command, Commands.deploy, deploy)();
+    await expect(withConfig(command, Commands.deploy, deploy)).rejects.toThrow();
 
     expect(loadConfig).toHaveBeenCalledTimes(1);
     expect(loadConfig.mock.calls[0][0]).toEqual(configPath);
@@ -84,7 +84,7 @@ describe('withConfig', () => {
       shouldErrorOnLoadConfig: true,
     });
 
-    await withConfig(command, Commands.deploy, deploy)();
+    await expect(withConfig(command, Commands.deploy, deploy)).rejects.toThrow();
 
     expect(loadConfig).toHaveBeenCalledTimes(1);
     expect(loadConfig.mock.calls[0][0]).toEqual(configPath);

packages/fuels/src/cli/commands/withConfig.ts

@@ -5,11 +5,10 @@ import { loadConfig } from '../config/loadConfig';
 import type { Commands, FuelsConfig, CommandEvent } from '../types';
 import { error, log } from '../utils/logger';
 
-export const withConfigErrorHandler = async (err: Error, config?: FuelsConfig) => {
+export const withConfigErrorHandler = (err: Error, config?: FuelsConfig) => {
   error(err.message);
-  if (config) {
-    await config.onFailure?.(config, <Error>err);
-  }
+  config?.onFailure?.(config, <Error>err);
+  throw err;
 };
 
 export function withConfig<CType extends Commands>(
@@ -28,15 +27,15 @@ export function withConfig<CType extends Commands>(
     try {
       config = await loadConfig(options.path);
     } catch (err) {
-      await withConfigErrorHandler(<Error>err);
+      withConfigErrorHandler(<Error>err);
       return;
     }
 
     try {
       await fn(config, program);
       log(`🎉  ${capitalizeString(command)} completed successfully!`);
     } catch (err: unknown) {
-      await withConfigErrorHandler(<Error>err, config);
+      withConfigErrorHandler(<Error>err, config);
     }
   };
 }

packages/fuels/test/features/dev.test.ts

@@ -1,6 +1,7 @@
 import { deferPromise } from '@fuel-ts/account';
 import { spawn } from 'child_process';
 import * as chokidar from 'chokidar';
+import { readFileSync, writeFileSync } from 'node:fs';
 import { join } from 'path';
 import { cwd } from 'process';
 
@@ -11,6 +12,7 @@ import { mockCheckForUpdates } from '../utils/mockCheckForUpdates';
 import { mockLogger } from '../utils/mockLogger';
 import { resetDiskAndMocks } from '../utils/resetDiskAndMocks';
 import { runInit, runDev, bootstrapProject, resetConfigAndMocks } from '../utils/runCommands';
+import { runInitTemp } from '../utils/testHelpers';
 
 vi.mock('chokidar', async () => {
   const mod = await vi.importActual('chokidar');
@@ -82,6 +84,24 @@ describe('dev', () => {
     expect(on).toHaveBeenCalledTimes(2);
   });
 
+  it('exits when build fails', { timeout: 30_000 }, async () => {
+    using temp = runInitTemp();
+    const mainSw = readFileSync(`${temp.contractDir}/src/main.sw`).toString();
+    const invalidSwayCode = `${mainSw}\nabi `;
+    writeFileSync(`${temp.contractDir}/src/main.sw`, invalidSwayCode);
+
+    const devProcess = spawn('pnpm fuels dev', {
+      cwd: temp.rootDir,
+      detached: true,
+      shell: 'bash',
+    });
+
+    await new Promise((resolve) => {
+      devProcess.on('exit', () => {
+        resolve(undefined);
+      });
+    });
+  });
   test('`dev` command can work with ephemeral port 0', { timeout: 25000 }, async () => {
     await runInit({
       root: paths.root,

packages/fuels/test/utils/testHelpers.ts

@@ -0,0 +1,34 @@
+import { execSync } from 'child_process';
+import { randomUUID } from 'crypto';
+import { mkdirSync, rmdirSync } from 'fs';
+import { tmpdir } from 'os';
+import path from 'path';
+
+export function runInitTemp() {
+  const fuelsPath = path.join(process.cwd(), 'packages/fuels');
+
+  const rootDir = path.join(tmpdir(), '.fuels', 'tests', randomUUID());
+
+  mkdirSync(rootDir, { recursive: true });
+
+  execSync('pnpm init', { cwd: rootDir });
+  execSync(`pnpm link ${fuelsPath}`, { cwd: rootDir });
+
+  const contractDir = path.join(rootDir, 'contract');
+  const outputDir = path.join(rootDir, 'output');
+  mkdirSync(contractDir);
+  mkdirSync(outputDir);
+
+  execSync(`${process.env.FORC_PATH} init`, { cwd: contractDir });
+  execSync(`pnpm fuels init -o ${outputDir} -c ${contractDir} --fuel-core-port 0`, {
+    cwd: rootDir,
+  });
+
+  return {
+    rootDir,
+    contractDir,
+    [Symbol.dispose]: () => {
+      rmdirSync(rootDir, { recursive: true });
+    },
+  };
+}

vitest.shared.config.mts

@@ -14,7 +14,6 @@ export default defineConfig({
   ],
   esbuild: { target: "es2022" },
   test: {
-    globalSetup: ["vitest.global-setup.ts"],
     setupFiles: ["./vitest.setup-files.ts"],
     coverage: {
       enabled: true,
@@ -42,7 +41,11 @@ export default defineConfig({
       "/apps/demo-react-vite",
     ],
     globals: true,
-    env: loadEnv(mode, process.cwd(), ""),
+    env: {
+      ...loadEnv(mode, process.cwd(), ""),
+      FUEL_CORE_PATH: "fuels-core",
+      FORC_PATH: "fuels-forc",
+    },
     poolOptions: {
       threads: {
         minThreads: 1,