-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Prod] Remove fields from the objective form on the RTR #2167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TR-objective-form
…RTR-objective-form
[NO-TICKET] Remove "yarn-known-issue"
…ses_on_ars [TTAHUB-2560] dedupe ARG and create timeseries functions, restore missing ARGFRs
…ty-report-updates-for-reduced-objectives
…names [TTAHUB-2986]Correct Spanish coursenames with unknown characters
…-RTR-objective-form
…B-2660/activity-report-updates-for-reduced-objectives
…tes-for-reduced-objectives [TTAHUB-2260] Activity report updates for reduced objective fields
[TTAHUB-2999] Create monthly-delivery-report.sql
…-form [TTAHUB-2530] Remove fields from objective form in RTR
Jones-QuarteyDana
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Removes objective sub-fields from the RTR and adjusts the Activity report form accordingly (see attached video)
Screen.Recording.2024-05-28.at.2.56.13.PM.mov
PR also includes two data fixes: one for the non-UTF-8 characters that were imported to the courses and the other to save historical root causes on multi-recipient reports, which were not cached originally.
We also add a SQL file to the repository, which can be used to generate a report at a later date.
How to test
Confirm that:
Issue(s)
Checklists
Every PR
Before merge to main
Production Deploy
After merge/deploy