Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Production] Update CLASS threshold date logic, add monitoring test coverage, update date filter logic #2552

Merged
merged 12 commits into from
Dec 18, 2024

Conversation

thewatermethod
Copy link
Collaborator

Description of change

This PR contains three changes:

  • The dashboards (Excluding QA) used the JavaScript date constructor, which adds an hour offset to a string. This means the filters would not encompass the whole day, merely most of it. We tweaked this implementation to make it consistent with the QA dashboard.
  • Monitoring services had additional test coverage
  • The CLASS threshold calculation on the frontend had it's date adjusted from 2025 to 2027.

How to test

None of these changes can be tested through the UI

Issue(s)

Checklists

Every PR

  • Meets issue criteria
  • JIRA ticket status updated
  • Code is meaningfully tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • API Documentation updated
  • Boundary diagram updated
  • Logical Data Model updated
  • Architectural Decision Records written for major infrastructure decisions
  • UI review complete
  • QA review complete

Before merge to main

  • OHS demo complete
  • Ready to create production PR

Production Deploy

  • Staging smoke test completed

After merge/deploy

  • Update JIRA ticket status

@thewatermethod thewatermethod marked this pull request as ready for review December 18, 2024 14:54
@Jones-QuarteyDana Jones-QuarteyDana merged commit 07d57bb into production Dec 18, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants