DropdownList: Filter text input in the menu #5915
Conversation
| if ( TextField == null ) | ||
| return; | ||
|
|
||
| filteredData = Data.Where( x => TextField.Invoke( x ).Contains( FilterText, StringComparison.OrdinalIgnoreCase ) ); |
There was a problem hiding this comment.
Do we need to store filtered data? Or can we just return it as
return Data.Where( x => TextField.Invoke( x ).Contains( FilterText, StringComparison.OrdinalIgnoreCase ) );
There was a problem hiding this comment.
Yeah, in this the filteredData field isn't needed. That implementation can go without it.
I took it form the Autocomplete, where it is an IList and the data aren't enumerated on every get. But made it IEnumberable, because the Data are also IEnumerable.
Well - it is a question now. Should the DropdownList.FilteredData also be an IList instead of IEnumerable?
- IEnumerable will do the filtering on every enumeration. Possibly on every re-render. This could have significant perf implications.
- If converted to List, the filtering will be done only on text change, but it needs to fit into memory.... This is also a concern for current implementation of
Autocomplete...
There was a problem hiding this comment.
Yeah, performance can be a problem. Dropdown, from a UX perspective is meant to be used only for small menus. With this new search features we are essentially breaking that "behavior" since we are allowing for very large menus. I guess that is fine if our users would expect that. But now we have a dilemma. Should we optimize or leave it as it is.
I think we can leave it as is, and optimize with caching later if it becomes a problem.
There was a problem hiding this comment.
In that case, the current state is final. filteredData is "needed" to avoid repeating all the checks unnecessarily, even when the filter isn’t dirty.
Another option is to keep everything (Data and FilteredData) as List -> that would signal "small" dataset and avoid unnecessary filtering on every get...
stsrki
changed the title
Description
Closes #5666
Adds a filter to the
DropdownList, bringing its functionality closer to whatAutocompleteoffers.The current solution has limited customization options for both the filter functionality and its appearance. It might be worth considering merging some features with
Autocomplete—for example, allowing customization of the filter type.I’ll update the documentation and release notes once the core functionality is agreed upon.