Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Add a note to state the limitations in CMK-encrypted registry #35

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

FeynmanZhou
Copy link
Member

@FeynmanZhou FeynmanZhou commented Dec 9, 2024

Add a note to illustrate the limitations of Referrers API support in CMK-encrypted registry. Related issue: Azure/acr#784

Copy link
Contributor

@FeynmanZhou : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 7e75ba3:

✅ Validation status: passed

File Status Preview URL Details
articles/container-registry/container-registry-manage-artifact.md ✅Succeeded
articles/container-registry/container-registry-tutorial-sign-build-push.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 84d6dde:

✅ Validation status: passed

File Status Preview URL Details
articles/container-registry/container-registry-manage-artifact.md ✅Succeeded
articles/container-registry/container-registry-tutorial-sign-build-push.md ✅Succeeded
articles/container-registry/container-registry-tutorial-sign-trusted-ca.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@Court72
Copy link
Contributor

Court72 commented Dec 9, 2024

@tejaswikolli-web, @yizha1

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged C+L Pull Request Review Team label label Dec 9, 2024
@FeynmanZhou FeynmanZhou changed the title doc: Add a note to illustrate the limitations in CMK-encrypted registry doc: Add a note to state the limitations in CMK-encrypted registry Dec 18, 2024
@@ -227,6 +227,9 @@ Storing individual (subject) OCI Artifacts are covered in [Push and pull OCI art

To store a graph of artifacts, a reference to a `subject` artifact is defined using the [OCI image manifest][oci-image-manifest], which is part of the [prerelease OCI 1.1 Distribution specification][oci-1_1-spec].

> [!NOTE]
> ORAS uses the OCI Referrers API](https://github.com/opencontainers/distribution-spec/blob/main/spec.md#listing-referrers) to store the attached referrer artifacts in the registry by default. The OCI Referrers API is supported by most of the ACR features except the CMK-encrypted registry. ORAS will fall back to use [OCI Referrers Tag Schema](https://github.com/opencontainers/distribution-spec/blob/main/spec.md#referrers-tag-schema) to store the attached referrers in the CMK-encrypted registry.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always used versioned tag or commit for the link instead of the main branch.

@@ -274,6 +274,9 @@ The following steps show how to create a self-signed certificate for testing pur
| Workload identity credential | `workloadid` |
| Managed identity credential | `managedid` |
| Azure CLI credential | `azurecli` |

> [!NOTE]
> Notation uses [OCI Referrers Tag Schema](https://github.com/opencontainers/distribution-spec/blob/main/spec.md#referrers-tag-schema) to store the signature in ACR by default. You can also enable [OCI Referrers API](https://github.com/opencontainers/distribution-spec/blob/main/spec.md#listing-referrers) by using the flag `--force-referrers-tag false` if needed. The OCI Referrers API is supported by most of the ACR features except the CMK-encrypted registry.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which version of notation?

Copy link

github-actions bot commented Jan 2, 2025

This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions.
Get Help
Docs Support Teams Channel
Resolve Merge Conflict

@github-actions github-actions bot added the inactive This PR is inactive for more than 14 days label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants