-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: "Thick" Pareto frontier #400
Open
MilesCranmer
wants to merge
16
commits into
master
Choose a base branch
from
thick-pareto-front
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
I think this is enough to implement that idea! The user can filter the list themselves if needed. For diversity filtering, I imagine something like: # X_out is the data points X sampled outside the training boundaries
for complexity in 1:max_complexity
exprs = hall_of_fame.elements[complexity]
similars = Set()
for i in 1:length(exprs)
for j in (i+1):length(exprs)
if distance(exprs[i], exprs[j]) < threshold
push!(similars, j)
end
end
end
deleteat!(hall_of_fame.elements[complexity], sort!(collect(similars)))
end What could be helpful is a function that implements this ^ and the user provides the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This puts in some of the groundwork for MilesCranmer/PySR#791. cc @folivetti. Basically if you pass
to
SRRegressor
, it will allow the top-5 individuals to be stored at a given complexity level, rather than only the top-1.The interface aims to provide an easy way to try other ideas for researchers – for example, here is most of the implementation of
ParetoTopK
:So basically this stores the best K individuals seen for a given complexity.
You now update the hall of fame like this:
This gets routed through to the specific element of
hall_of_fame
, which would then (internally) callAnd the given
AbstractParetoElement
type can consider this new individual however it likes.I guess what is missing for @folivetti's idea is some way to measure diversity. Right now the pareto element type can only see the genotype. Would we want it to have access to the phenotype (evaluation result) as well? This seems super tricky to me because a user can also implement a custom loss function. How can we do that in a generic way?