Add filter for max transaction size

[marcindsobczak]

Changes

• add filter for max transaction size
• setting max tx size to 128 KiB which is inline with Geth https://github.com/ethereum/go-ethereum/blob/master/core/txpool/legacypool/legacypool.go#L56
• setting max blob tx size (excluding blobs) to 1 MiB which is also inline with Geth https://github.com/ethereum/go-ethereum/blob/master/core/txpool/blobpool/blobpool.go#L63-L68
• skipping requesting tx in PooledTxsRequestor if tx size is exceeding configured max size
• moved TxType comparisons (e.g. SupportsBlobs) from Transaction to TxTypeExtensions

Types of changes

What types of changes does your code introduce?

• Bugfix (a non-breaking change that fixes an issue)
• New feature (a non-breaking change that adds functionality)
• Breaking change (a change that causes existing functionality not to work as expected)
• Optimization
• Refactoring
• Documentation update
• Build-related changes
• Other: Description

Testing

Requires testing

• Yes
• No

If yes, did you write tests?

• Yes
• No

[LukaszRozmej]

We could add similar logic in transaction gossip, before we even deserialise RLP. We could avoid deserialization and serialization later. Also NewPooledTransactionHashesMessage68 have size property that we could leverage and not request transactions over that size at all.
Do we want exception for local transactions? (probably not)

[marcindsobczak]

Good idea with not requesting txs with size above max limit!

About skipping deserialization - we need to deserialise at least a part of tx to check tx type. But I think we can reject at the very beginning all txs with size exceeding maximally loaded blob tx (max number of blobs + max size of non-blob data).

About exception for local txs - I don't think so. If user would need to send such tx, there is always an option to increase config value

[LukaszRozmej]

Good idea with not requesting txs with size above max limit!

About skipping deserialization - we need to deserialise at least a part of tx to check tx type. But I think we can reject at the very beginning all txs with size exceeding maximally loaded blob tx (max number of blobs + max size of non-blob data).

About exception for local txs - I don't think so. If user would need to send such tx, there is always an option to increase config value

We can get the type without deserializing anything else, it is just first byte.

[marcindsobczak]

Good idea with not requesting txs with size above max limit!
About skipping deserialization - we need to deserialise at least a part of tx to check tx type. But I think we can reject at the very beginning all txs with size exceeding maximally loaded blob tx (max number of blobs + max size of non-blob data).
About exception for local txs - I don't think so. If user would need to send such tx, there is always an option to increase config value

We can get the type without deserializing anything else, it is just first byte.

There are some exceptions like legacy txs without tx type. For sure it's doable, but requires more insights, time, caution and extended testing, which I don't want to do in the scope of this PR. I added an issue for it: #7986

Here I added:

• TxType comparisons as TxTypeExtension
• limiting max blob tx size (excluding blobs)
• max blob tx size as config value
• not requesting too large txs in PooledTxsRequestor

[LukaszRozmej]

why blopb tx's can be 8x bigger?

[marcindsobczak]

Doesn't have sense to me, but I wanted to do it similar to Geth implementation
https://github.com/ethereum/go-ethereum/blob/master/core/txpool/blobpool/blobpool.go#L63-L68

[marcindsobczak]

And it is not a big deal as blob txs are saved to disc. Memory is not affected as in case of non-blob txs

[marcindsobczak]

We can also go with standard 128 KiB and it will simplify this PR, but we will then reject some txs accepted by Geth