Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixosTests.acme is very flaky #374792

Open
vcunat opened this issue Jan 18, 2025 · 1 comment
Open

nixosTests.acme is very flaky #374792

vcunat opened this issue Jan 18, 2025 · 1 comment
Assignees
Labels

Comments

@vcunat
Copy link
Member

vcunat commented Jan 18, 2025

This is a longer-term issue. I'm annoyed from having to restart the test all the time to unblock channels.

Examples (unstable, 24.11, both Linuxes):
https://hydra.nixos.org/build/285602524#tabs-buildsteps
https://hydra.nixos.org/build/285602583#tabs-buildsteps

.meta.maintainers: @aanderse, @arianvp, @emilazy, @flokli, @m1cr0man

@m1cr0man
Copy link
Contributor

Current plan to tackle this:

  • Review history and ongoing build failures for patterns (it tends to be something different each time)
  • Investigate the dependency chains in acme systemd components for potential race conditions during activation
    • One thing I only recently learned about config activation is that systemd jobs start one service at a time rather than a bunch together. This challenges some assumptions I had about service startup ordering. I need to review each service used in an acme renewal to ensure it depends on the right services in the right order.
  • Restructure the test suite by breaking it into many smaller integration tests for particular feature sets
  • Get nixos/acme: Refactor setup process #355087 merged to reduce the number of services and thus the dependency chain
  • Consider adding a target unit for correct ordering of the web server required for HTTP-01 renewal. There are some vague assumptions made currently and this could be causing issues.

I'm open to any other suggestions too. If anyone is eager to help, the first and second tasks would be great to get eyes on.

cc @NixOS/acme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants