nixos/acme: disable rate limiting to fix the test #374984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes the nginx reload service fires too fast so systemd kills it.
github-actions
bot
added
6.topic: nixos
|
/cc #374792 |
github-actions
bot
added
10.rebuild-darwin: 0
amarshall
reviewed
Jan 19, 2025
| # if a lot of certificates are renewed in quick succession. The reload itself is cheap, | ||
| # so even doing a lot of them in a short burst is fine. | ||
| # FIXME: there's probably a better way to do this. | ||
| StartLimitIntervalSec = 0; |
There was a problem hiding this comment.
FWIW, DefaultStartLimitIntervalSec=10, DefaultStartLimitBurst=5, so by default restarting more than once every 2 seconds would cause the rate limit to be hit.
Might make sense to also set RestartSteps and RestartMaxDelaySec so it backs-off with successive attempts, as RestartSec is only 100ms by default (or RestartSec could be increased, 100ms might just be unnecessarily fast.
There was a problem hiding this comment.
It's not failing restarts, it's just triggering the start a lot.
dustypomerleau
pushed a commit
to dustypomerleau/nixpkgs
that referenced
this pull request
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the nginx reload service fires too fast so systemd kills it.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.