xcodegen: bundle included settings presets #374925
Open
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
github-actions
bot
added
10.rebuild-darwin: 1-10
10.rebuild-linux: 0
DimitarNestorov
approved these changes
Jan 19, 2025
There was a problem hiding this comment.
Issues seems to be resolved
$ git fetch origin pull/374925/head:push-ymptwpxxptxk
From https://github.com/NixOS/nixpkgs
* [new ref] refs/pull/374925/head -> push-ymptwpxxptxk
$ git switch push-ymptwpxxptxk
Switched to branch 'push-ymptwpxxptxk'
$ nix-build -A xcodegen
/nix/store/9flcgf9pgzwk4yqqnjhmipgjh31kmc9i-xcodegen-2.42.0
$ echo "name: Test" > project.yml
$ ./result/bin/xcodegen --version
Version: 2.42.0
$ ./result/bin/xcodegen
⚙️ Generating plists...
⚙️ Generating project...
⚙️ Writing project...
Created project at /Users/dimitar/Projects/nixpkgs/Test.xcodeproj
wegank
added
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XcodeGen comes bundled with default settings presets. I assumed that xcodegen would be able to reference the presets because they were packaged as resources in the Swift project. However, the version of xcodegen currently in nixpkgs isn't able to find them, so I've copied them directly to
$out/share, which lets xcodegen find them.Resolves #374898.
See also an XcodeGen issue about this same problem
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.