Added C++ code for lowest common ancestor problem solution using binary lifting #6786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gargantuadev
reviewed
Oct 5, 2024
|
|
||
| void dfs(int k, int p, vector<int> &depth, vector<vector<int>> &adj, vector<array<int, 20>> &ancestor) | ||
| { | ||
| ancestor[k][0] = p; |
There was a problem hiding this comment.
Maybe I'm wrong, but I think we are not considering here the case in which k is the root node.
The change I would do is:
if (p == 0) { depth[k] = 0; // Root node ancestor[k][0] = k; // Root node's ancestor is itself } else { depth[k] = depth[p] + 1; ancestor[k][0] = p; }
What do you think @berkay-top ?
There was a problem hiding this comment.
I don't think it is necessary because the default values for arrays are already zero.
There was a problem hiding this comment.
Yes completely agree, I missed the implicit initialization, nice job by the way!
gargantuadev
suggested changes
Oct 5, 2024
AdiChat
approved these changes
Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue:
#6785
Changes:
I have added Lowest Common Ancestor problem solution with binary lifting in C++.