Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for increased Effect of Small Passive Skills in Radius for Time-Lost Jewels #443

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

Peechey
Copy link
Contributor

@Peechey Peechey commented Jan 20, 2025

Description of the problem being solved:

Scale small passives in radius of Time-Lost jewels with the increased effect mod. This also scales any mods the jewel itself is also adding to small passives. Allocated passives update instantly when the jewel is edited, socketed, or on load. Unallocated still take a hover or two to get there, but ultimately the stats/calcs are correct when it matters. Added a blank parse for the mod so it's blue on the jewel.

This effect is additive with Warrior Titan's Hulking Form ascendancy for a maximum? possible of 80%

Identical mods do not merge yet, but I will have a PR out for that soon. Also moved the ProcessStats call up so we don't run it way more than we need to. Once per node per jewel is plenty.

Link to a build that showcases this PR:

eNqlW1tv27gSfq5_hWDgALs4TqK77SDZheM4l4Mkde203d2XgpFpm1taciUqibvY_36GpCTLF8pU0odWFucbzgxnhsOhevb764IazzhOSBSeN61js2ngMIgmJJydNz8_Xh11mr__1jgbIjb_OL1ICeUj9m-ND2fih0HxM6bnTbvdNAKKkuQBLfB5c4TCGY6bBkoCHE7664GHKMRNg6F4htmXfFbzmwXoOYpRwHB8xzn2UhbdRxNAsDgFxAKRcBwF3zG7jqN0CZI2jWeCXyTN7f3w4-ixCVJ9OBtStMLxmCFmJPDXebMH2qEZviEMIIimQG82TyppL9I4YZdoAY-HMeMlxpPDZP2YsPuUMrKkhJsmo7dV9CBvf47CYC2BZSqZP0YM0cvh-LAYkjLSsMVXwuYXFHTT4supb2chYVibfBiRJAprSa1F3E8pBSfVoh3hBMfPiBFNQfrR4omEmja5RyHqRwnToxziGIKF1QKMcRBBfNWdoybyjkyxPmUtPTJAXWnepsdgrEtXm_HbBBpBgtGjHEcp1aRk6-Ri2cr0colf12Seiuo2XM_YVsfQjzKd5XTVkz5HPNQ0A35wMywoPcs6di3T8duO63tKgYfzVUICRO_RK1mkC0iij-g7Xk_Ytjtqv5rNWQiJQ4X1bKW4VyTGb4D1Izp5C2yOokSF87uVkbOm8-yKHS045cS3YVDQd6q4fg5jkUhLG2EFf44YQZjwzfaJYl3IepIs2nR2RjnXDIfZhCu9BHOHcTC_hqJjhBjWy62lcKq2LCcuW7aS6x7LVvDfRNQwEwfuN5N_bFWBahpqvCQx0ZJIUu5TXx9TwwCDEMez1XhOMF1P1fZ1yHOT9dFSAylcoAzXcoXN-Wq5cxlac7X4_lR3tmeUlDO8ZXaqLSHp9eIBQzkKgAneqoyViGEc_Y0DRmg9WC9eRGmsVfoHp5JYS4F8d5JHixGepIHedjiYTrkaz_iCwiFIV40CBXJSWgvaYwwF3y-jyUzbaGKSWohN-cbpcgmBy71BlwHfdqGCJ6W66MjVoP4IvlyO1soNWn-CNbX2BEXRoT_LFkRfF141bE2jQ6w9QbGc95ArFpB3xckYTujrZKBcGjiyaR2pBKHmOXAYvYDkc95rSOpRQ21VABylKDEOf660-W-Qa00wCCdpzANBe45txL5p7kkIEbbb89hqd3jWcdtyOl23Y7ZN31eBN5sf1rFpvZ9yp5nh2ce2A7W_0_Y8y_GrcXtaGzuUe1sbmrPsb3TUAO-2PWrqt8_5d4grmiA7tAeaILu89zRBNHXYOIK4pm1WEVaXHnsh1QXODmRv1adFXVM2_SLsIp1OEyMAEyN2B-n3vNk0nuBd_hykcYKzHxLxSBZQGCXJJWLImGRH7C8oJihktuiUJhjFwZyDrhClT7Czc07rt-KX6K5eEcpwfAnveBrhUm1ztPI0fnYiOsD86XaxjGJm4Ff-zxDFbHXenCKaYEko3gCfhJFQeBkkHUqbxngevfQmz3ymxyiiSQ4y0HKJw8kGj8cYYwPl1ULAhRDK8x_GAiUg9UpuQAnXptR4vp0INcIIBACY5bftlme6XrfV8fxuy-16lt2y3Y7ttVyn7fotr-PY3ZbnA03La7cts9XxLb9leR2z23I6luvAoO9ZLa_r-HbL6li-CQx8t93yLavrtxwXIqDlWF3PBAYmkPgukLhtq91uuWa743BmHZjP71jdlt1128DYstpey3F8x2rZtqABPvDsd12PLxZvK6F41dvULCRgSAbG2eqmrzXnZvpw9nl0Jx4-zBlbJqcnJy8vL8dLxObRFL9CfXwMHneyBBAY-Cj5Tig94lxPevDnYtbr3RD7z9s_wgt0fen9SO_-ticxc7-68x-XzgUdfpuMj6Zk9HwxGx117udf5p2f87-uPw1W7viv7nA4s23XuQ9xgC__sP7-9nD9sPz0qdcTgp3kkp3J_n4ixcx-iWXjegjDNA1Iuwv-M9s8AF5GnfFaJSaw0BkTKGNj8pQynA-AF74-SE8AZiErnhMWP5Q9ROUbwh-kE8jVk05QXnjFkstllosqXUz6jHQF4WLS54TjFPptqATqgr-L4OMBwR8eIibH-Mv8x9mYr2ACQR2za7xILlaQq6948tnK3llEceoxZjJZlDH5_csET1FK-ftPKaKEB7hZfnsnr4HCKF4UzTdgBQHOy3rJ8XG15Pbt3d1loZvNapBJHs7ZS3Hd01uL1kc0SIRwJAxoCh4RZhVjkTIoeuIC8Nsr3lOalC-OSpyKiT6cgUQiOYMEtyG4RRZLEn9NoydE7ZyLCIgsqW8KVBrJXvYgnYE3ISq7EY9pzHiPK78oMzensPIpnmV65c5d4hATwpJslq0hzjyRJeCugEK2H6Wlmsm4uccMTWCfOLmFQEpOwAYngh4eZGKBZLzangSSJ1pkabcYM4rBLYsHURpmnlSybmYcYeKSsCpzFdHNSTPPz9xFeL_0b_4oGAuK23CZMiHqeZN7npwBdk_YWzAKy9vJFjFn9i1MF0_clPLf9WGlTLkgSfCN78b83lEkDXFPOri6GvQfb78MMsgYi3O9kaRPiXw8b34h-EVIfQlLQGjCDUUpWia42OhEIGRqUsBVcBNUN6S4pNzPa02g5jR4xTHsy7OvUAzEBCvlKsYPCCUn5GURr0tU3HiZrmYkuw992NVliaSwlDhRqLn0pXvuB_PBCixUNIgqZ85GD1iC8XwHQUOmJOClYPWS8-woqSrsEkD1h4JVxXpnrRM1D3HuUTGQg2qwPLuo0NlohVXFuUlpVTmqhl_iACl1l4NqcFF1R6H4FGA_l4KqgtMDHJO4k0PQ9AjljQ7lyg4oLkjUDD-yOY6z4lXF6R4yT05SGTiy3lHyKVFU2Eqc0hQW4mNqqLwJUejAxyqCJrsbUEU7qQ7ZzbOcYj3KNGpWsvGltGHWRKtYhqx_rFgCOVqhSd5DVyiRDVcEisjBveeITGQjVREyW2RVSQOq7PezEd3h97PZbhe_n-MVHJe-K9c7G1XDPzPCC609XGRJpMWEB9b7OPD4eh8H3jdcvBk92i5F1thRdRFSdDj3gvPRqtjPGp9v5iDbs2-Gi-7xm9FiA7jEU8xr4aodoKCpCA6WhpdgDFYRGJqshFj7s8hau1q85F64V9PaHGV0Zx8_VCUASXKAEWzmNxXloh6n4gbkBiPKO70RfR_DnY883sOMdyvTJQonObuP-4r09TpoWi9iCfAUvcBL3hR9rw1DvFjtYaSW6-wkPwOKLiE_aGW9zTGLeUvgZxQt_oQDnd9xjk234_q27Ti-fJ81Liwn61ZABX5JYBlj4X75tJzyj_Pmke8fdx2_Y3fbblt-hHEmDtJZH4U_F20UNbc0wfIrsa8YLeHAzhHSTvLACVzKPZERgsJndWqMeqNB42a1DCNGAqOfsgZfvKO7KGHGGC2XcxLjhgALpU6NttcYoQlJk1NjvECUNuDcQkkAbn5qmA3b_w9vp8QYgX0N6bpGNJWkxlC2Ao2skURCQ7JqVA8boEZkzCAXM0OevxNjAsFg2OXJ5Ao2HiLGOwe1mM0REFplZvKwaIAPGvzEaIhjoegewCFdfIhsxPzv86Z57DUzw0r_E12Qtc2zFgz_KFeQ2Zv2__xw--nzoNGj34F2QGLUuKDoJ7hvH-oQmFdUlQ1Z3Z0aVrshq81sAN6YjayHfmoMY2yYx9axtX7VT2NwE9aQZ39QrBixG1nTDR7N8iJajWtunERaDjwEkQTngvwjtD4Fpf_9xTGPXPPXstVERcc_ugbH3Cb1NkmlRsLAGxo1_skMdmr9W-Lw318s78gxfzVYZCxk_jJ4ZbImtzfJPfOovYdcOokUFKQgiSETGDyjRJLoLHIFhX2QwjlI4R6k8PY7m2S_G-APkL04QWPwusQxM4Y0XYDKV1EAwbflUW2_0Y_RFJzl1OCppQFuNSWvpwb_zL7ixzid6vwoe13WZodMYowbozTEGU3pUWSdEf4hEs9GqtnRnnd91VlwsyFMIyba_sOnz6M7ns5lK-6aRs-8hMhvBIqOuQogpzGsGhBR8dZC9BYpxawGQFTchlMbUV8Nu76tShDnEOQCU_aG1TDGL_zbEm3cCAq1WqpcRJOVkR_IaxvgTeJZtVdzr0Ii4m4nQL59Cyah_8MvmBqli7Gc9YEpbzBU4ayWCSO2G2kypGVDnldeaALxzKuur5h_oZTI0kyUR6JPH4VTMssKJfkjK5UEvnhjMMIo5v08cbe0mQyGFAV4HtEJjjPZMC8Xs29L8s592yxUUgA2voXKYYdAxYdXedO9uCkwbfvQhPH6v_PkME-NGc9h8ce8rkl2LiTUc8CbN4jGP4t7A0xk-zWi46rpF8V_e-Lfv0AxPBGq9flFEVQ709K8noaO2-vmaS_ckB-hcpiji6o9n_CubZO6ZldjIWpJuPk5aT1_hDe15ip_aqljiHEQiQNYPRfOPoyFU5-opcohfQCZZ_hiJrvTNTWCctt2TgUoITNCP05Frwc0Ew0rXc2Knm4RMFUR05_zS8D9xoPjbp4r5eFX_PqtcXay8580_w8ARJAI
eNqlWt1S4zoSvh6ewpWqvcuAHYf8UGFOBRIGzsKQiYHZ2ZtTwlYS7chWji0Dma19921JtuOEyJEDRYFt9ddqdatb3W0P_ngLqfWC44Sw6LzhHNsNC0c-C0g0P288Plx97jX--HI0mCC-uJ9dpISKkdaXo08DeWNR_IIpADsNy6coSb6hEJ83fqA4JixuWCjxcRRcrkceCEdRw-IonmP-lM9r_-UAfoFi5HMc3wqew5SzOxYAhMcpblghIpHH_F-Yf41ZuoQpG9YLwa-K5uZucj99aIBcnwYTilY49jjiVgJ_zhtDWB-a4xEK4S-gEE0BYh_bnU7jpBJykcYJr4PzlhgHBalz3NIRTmI8ns2wz8kLvowJv1ygyC9NosPVpb1LKSdLSnBc0Gtlun7H2tHSPjCO6GjildXS7e8hZ3y_0D8IX1xQ0KI5cwG5mUeE43qYCSMJi-ovYgOhVX5KKbiKEe0UJzh-QZxsSaPlzcJnEtVR0R2K0CVLDPQvKCc4BrfltQAe9hl4et05aiJvyQybU9ZaRwaoK81h6xh7pnS1GR8m0BRCnBmlx1JqSMnXQafn6KhG-K2g6uqIbiK-n2iEX5jwof2SSU8eX08KSrd1ety3bbfjuG63rQ3vk8UqIT6id-iNhGkIAfMB_cLrCdstR79X5gseQUTQYV1bi70iMT4AdslocAhsgVhywArv4IS-RlEw9P0UDvLV2vaVDmTCGo5V_0wQ30T-mm0V18colkG1dBpXGmeGp-At4tR_ptgUsp4kc7r1wWnb1XPNcZRNuDKLM7cY-4uvoOIp4tgsxJak6VVqVhCXNVvJdYdmK_hvImqoSQB3q6l97FaBairKWxJIk0wkUpQ7l2-MqaGAcYTj-cpbEEwDg7hfos41domWJuuHDVBGG22EzelqbeYytKatxCFVd7YXlJSPhO5ptSIUuZkzYEhTARBg04R8ErP_iJSf1oMN45ClsaEpFbHRAvLTTBU4UxykvtnxWVQuFxQqMtNlFCiQk9Ja0CHnyP81YsHcWGlyklqITfm8dLkErxW7wZSBOKYhlSel3Ohz24D6Hrayka-KA918gjW18QRFkmI-yxbEfC0iy9iaxoTYeILCnHcQKkIIurI2v2OluK01DdRuRoWYJDQsCCfsFSRfiMZHUo8acrF13qYVJcbR75Ux_w1yownGUQBpHTiC8RzbiF3TXKSzWWL5UNAifgvmPW80rGd4ll9DKpng7EYhHkgIgTdJRogjK8hS_icUExTxlmwLJRjF_kKArhClzxA5BKf1U3G3BXTy3TA4kX0tcXUTLlnMLfwm_k1QzFfnjRmiCVaE8gnwSTiJZOkOYYrShuUt2OsweBHrfmCMJjnIQssljoINHg8xxhbKg44vhJBrFDdWiBIOZ5zax4kQutRNuwnkUiMGAsCV43R7zdN2z3GaTr_dajc7rU6_2eravVazY3fcdvO02-vZTahz4LrluL1us9Xptk6Bpu30mu2u0z1tuv12G65P-3272XEdByi7btdtQlHU7zadlt1tQt3gCEK3Axy7tts8dbtOv-koXq1-q9d0e27LFfoW1SeKV8NNqSMCSuKw8K3u33pVQgWfBo_TW3nxacH5Mjk7OXl9fT1eIr5gM_wGR-gxbJqTJYBAeZ-TX4TSz4LryRB-Lubji6tV-rez4Lfti0Uf-XHSSm9-PrY5-_ePBIUL8nv5gv6JUtt--u65Abqb_Ly_iuwguHh6Cr_T5zvgcn4uBTnJJRmo_mOixMrupAmE3FKdDYtwHKplnCjQSRk1EOErJmC0jAmcbDF5TjnOB2BHvX1TVgVmES-uEx5n11LBmbWVgZShS2ZS1tNZSNq_kG9DJBAX9p50BLE5xcU3xtWYeJjfDDyh8cRKwDe-4jC5WEEQvBI53VZ7KtvdgtrDXPlnGZP3dwM8QykVz7-niBLhbHb56a1qNEcsDov6G1iBs4mTWnF8WC2Ffoa3t5kbZbNaJFj7txJcXF4i6qtF30TLFCwpO9QhSfy_RAgSnWWpdtkLH19djS8fbp7GWRgqQ-Tu-ytKw2fRZlX_18eLh2VaZSXpc6IuzxtPBL9KQUaYI0IhmPqMUrRMcBEgpNDZCijgKrhJKijV8071bl5rAj2n8RuOIZ7Nf0CsjAnWylWM7xFKTShydRG2ddxEY1jPSCV_lxANVZWg0ZTsvOu5iGa4djlisAILJwGi2pmz0T2a4GJvgmuRGfHFGVltcrGTFVWFXoo-i9beWeaq5yE77ToGalAPVv1zHTobrdCqbNlrtapG9fAR9pF27WpQDy4KTxZdi-p_N5eCqoLTNxbJTQ5OMyRU5Jlay44pLkj0DO_5AsfZoa_jdAcxKiepdBx1tmj5lCgqdCWbdBoNiTE9VHWhNGsQYxVOk_VldN5Oql12s3uisUeZRs9K1R1aHWY1TIUZsvJdYwI1WrGSvIOhWUQ2XOEoMgYPXxgJVB2rcZktsqqgARnNx9nI4vzjbLar9Y9zvIJU9JfW3tmoHv7IichfdnBRmY4RE-FYH-Mg_OtjHETZFh6Mnm6nImvstDoJKQrMneB8tMr3s7rzYA6qOj4YLov3g9HyABjhGYYVVJ4ABU2Fc_A0GoEyeIVjGLKSYu2OIuvV1eKlzsKdK63NUXl39q6qKgAokj2M4DC_rkgXzTgVDahrjKj42oDRjzF8907uI8xECz1doijI2d3vStLXdjDUHuMJ8JQ9lJHo1H9UhxEOVzsY6eUanORlneyuiEIra_14PBZ19G_Gwp_njc-ObXePO92e22vDr3qeFZmOk1WWkIGPCJgxltsvn1ZQ_ku-9eodd6DOhsrfcdU748ENlP9JVvSK66Lm1bNLE6ze1P_AaMkiiRBNElVmAo-sfJXl-hRB3rM6s6bD6fjoG6xNEBwJu32-ZQm3PLRcLkiMjy5jNOM4OLPEJEeTGM_I25kF2erWjQeVrrj5L0TMOT5z_vcnfsV0igKSJlDsi9ehaiMXlBImNTXFf59Z9pEiPrM8qMzpEZRDlPjgPWLItf9hkciPMQKzWYqRxWaK1Jqo7o2V9RJIZClWsi8B5fdUiGRJwcQHLqeNUiEPhhZLL5QkynydJssKHHiUcdmlmTw_Tm_FjlBF_FcKZWqybuDYeYNEB1CTWE4NiDw0ayGGYUoxrwGQh7bl1kbUX0arvq7qQC4w5QdYw_JexdsBY9wUYn09uViwsvKc_j1KNvtuAoBsdwYVXLqXVWoW5uwNNXjQ-pza26GORq4xHOS8lgoZf-9pyqHBaWUUl4FUdulYNCPzLKSqmyyoSlDxZMPJJxT5eMFogONsTixOkuzzzLxD17ULUTWAjbdUOWwfqHgllvfjio6g3Wrtm7D0fWcOO92DKb93LDB7VwZPDpBPzHUATB4XawSct1r6sPhiVXyjCWdl4Mn-H0sj7mE6K817arDG2ooprDcRKVYOc01R9Q0htti2Stt2fw-saAsUOq1SqreAuCT1mLxrUGun2Pw-oN42hiem-vN8JrOzesJlHy1ASiizhLJT70HmsbuYqdXrV2ASMif0fiZrOhBSFqamQgpv3taeaxu4mKnuLhfi_cBu1UEmnMdGlRfLuy9Hg5N3X_P_H7OieOg=

image

Before screenshot:

image
image

After screenshot:

image
image

@Peechey Peechey added the enhancement New feature, calculation, or mod label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant