-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add methods to expand coverage of channels
endpoints
#55
base: master
Are you sure you want to change the base?
Conversation
@evanofslack just curious to know is there any specific reason to return slice of User addresses in GetChannelMembers function ? |
@srrathi The function's intent is to return a slice of func (c *Client) GetChannelMembers(channel *models.Channel) ([]*models.User, error) |
I'm sorry by addresses I mean Pointer. It is returning a slice of |
@srrathi Only reasoning is that other methods tend to accept pointers and it is easy to dereference if necessary. |
evan slack seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This PR adds methods and tests to cover the following endpoints:
The method for
users.info
was required to retrieve user IDs for testing ofchannels.invite
.Additionally, this PR moves
groups
methods out of the channels file and into a new file.