Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re written chapter 25 + renders with quarto #291

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

pachadotdev
Copy link

Hi @hadley @Tazinho @henningsway !

As I mentioned to Hadley, I was interested in working on chapter 25, to which he agreed

I have uninstalled R completely, and then tried to render the book adding one dependency to imports at a time. Then I made multiple changes to make it work with Quarto, which works well with the HTML, but not with the PDF (unless I set some chunks that I commented in the commits list to eval = F)

@henningsway
Copy link
Collaborator

Thanks @pachadotdev, this looks very good. Looking forward to @Tazinho perspective. :)

Regarding the Netlify deployment, we'd have to adjust https://github.com/Tazinho/Advanced-R-Solutions/blob/main/.github/workflows/bookdown.yaml as well.

@pachadotdev
Copy link
Author

Thanks @pachadotdev, this looks very good. Looking forward to @Tazinho perspective. :)

Regarding the Netlify deployment, we'd have to adjust https://github.com/Tazinho/Advanced-R-Solutions/blob/main/.github/workflows/bookdown.yaml as well.

good point!
this is a complex project, one that would serve a very good purpose for a posit blog post about "rmarkdown to quarto" corner cases

@Tazinho
Copy link
Owner

Tazinho commented Mar 2, 2024

@pachadotdev thank you very much for your contribution. I haven't yet looked through the content, but in general I am fine with an update. However, I guess the biggest challenge is the technical setup for now. Am I correct that we could just go with the following steps?

  1. Bring the old version to some new branch within our repository, e.g. "AVDRS-E1-2021" (including the instruction for the PDF rendering - just to be clean and not lose it)
  2. Merge your Quarto Version on the main branch? (PDF is not needed as there is no 2nd edition planned)
  3. Make the Quarto Version work with Netlify

@pachadotdev
Copy link
Author

@pachadotdev thank you very much for your contribution. I haven't yet looked through the content, but in general I am fine with an update. However, I guess the biggest challenge is the technical setup for now. Am I correct that we could just go with the following steps?

1. Bring the old version to some new branch within our repository, e.g. "AVDRS-E1-2021" (including the instruction for the PDF rendering - just to be clean and not lose it)

2. Merge your Quarto Version on the main branch? (PDF is not needed as there is no 2nd edition planned)

3. Make the Quarto Version work with Netlify

@Tazinho happy to, I could not find a "good" way to render the site as is
let me ask the Quarto experts to find a way to render the PDF in a way that is reasonable
the other option is to restore the old branch, and there paste the new DESCRIPTION and the Qmd/Rmd chapter I edited

@pachadotdev
Copy link
Author

@Tazinho I just pushed changed to the GH-Actions that render with Quarto and publish with Netlify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants