Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling #528

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions __tests__/cache-restore.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ describe('restoreCache', () => {
);
});

it('should inform if cache hit is not occured', async () => {
it('should inform if cache hit is not occurred', async () => {
//Arrange
hashFilesSpy.mockImplementation((somePath: string) => {
return new Promise<string>(resolve => {
Expand All @@ -74,7 +74,7 @@ describe('restoreCache', () => {
expect(infoSpy).toHaveBeenCalledWith(`Cache is not found`);
});

it('should set output if cache hit is occured', async () => {
it('should set output if cache hit is occurred', async () => {
//Arrange
hashFilesSpy.mockImplementation((somePath: string) => {
return new Promise<string>(resolve => {
Expand Down
4 changes: 2 additions & 2 deletions __tests__/setup-go.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ describe('setup-go', () => {
getManifestSpy = jest.spyOn(tc, 'getManifestFromRepo');
getAllVersionsSpy = jest.spyOn(im, 'getManifest');

// httm
// httpm
httpmGetJsonSpy = jest.spyOn(httpm.HttpClient.prototype, 'getJson');

// io
Expand Down Expand Up @@ -143,7 +143,7 @@ describe('setup-go', () => {
expect(main.parseGoVersion(goVersionOutput)).toBe('1.16.6');
});

it('can find 1.9.7 from manifest on osx', async () => {
it('can find 1.9.7 from manifest on macOS', async () => {
os.platform = 'darwin';
os.arch = 'x64';

Expand Down
2 changes: 1 addition & 1 deletion docs/contributors.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ Pull requests are the easiest way to contribute changes to git repos at GitHub.
- Please check that no one else has already created a pull request with these changes
- Use a "feature branch" for your changes. That separates the changes in the pull request from your other changes and makes it easy to edit/amend commits in the pull request
- Make sure your changes are formatted correctly and consistently with the rest of the documentation
- Re-read what you wrote, and run a spellchecker on it to make sure you didn't miss anything
- Re-read what you wrote, and run a spell checker on it to make sure you didn't miss anything
- If your pull request is connected to an open issue, please, leave a link to this issue in the `Related issue:` section
- If you later need to add new commits to the pull request, you can simply commit the changes to the local branch and then push them. The pull request gets automatically updated

Expand Down