Review PR: Add "Offline" SDLogger Mode #676
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…working fully yet
…rsnapper_V2 class
Use latest build artifacts
New checkin model class added along with functions within .cpp to exec. it
tyeth
reviewed
Jan 9, 2025
tyeth
reviewed
Jan 9, 2025
tyeth
reviewed
Jan 10, 2025
tyeth
reviewed
Jan 10, 2025
tyeth
reviewed
Jan 10, 2025
tyeth
reviewed
Jan 10, 2025
tyeth
reviewed
Jan 10, 2025
tyeth
reviewed
Jan 10, 2025
tyeth
reviewed
Jan 10, 2025
tyeth
reviewed
Jan 10, 2025
tyeth
reviewed
Jan 10, 2025
tyeth
reviewed
Jan 10, 2025
tyeth
reviewed
Jan 10, 2025
tyeth
reviewed
Jan 10, 2025
tyeth
reviewed
Jan 10, 2025
tyeth
reviewed
Jan 10, 2025
tyeth
reviewed
Jan 10, 2025
tyeth
reviewed
Jan 10, 2025
tyeth
reviewed
Jan 10, 2025
|
@tyeth Please give this a re-review. I have changed what we discussed. I'm going to merge this branch into the api-v2 branch after you give the OK. |
tyeth
reviewed
Jan 14, 2025
| case wippersnapper_sensor_SensorType_SENSOR_TYPE_UNITLESS_PERCENT: | ||
| return "%"; | ||
| case wippersnapper_sensor_SensorType_SENSOR_TYPE_AMBIENT_TEMPERATURE_FAHRENHEIT: | ||
| return ""; |
There was a problem hiding this comment.
This looks like it's missing
tyeth
reviewed
Jan 14, 2025
| case wippersnapper_sensor_SensorType_SENSOR_TYPE_UNSPECIFIED: | ||
| return "raw value"; | ||
| case wippersnapper_sensor_SensorType_SENSOR_TYPE_ACCELEROMETER: | ||
| return "m/s/s"; |
There was a problem hiding this comment.
feels like this should match gravity/linear-acceleration, but happy to not have it match if preferred
tyeth
requested changes
Jan 14, 2025
| case wippersnapper_sensor_SensorType_SENSOR_TYPE_BOOLEAN: | ||
| return "BOOLEAN"; | ||
| return "raw value"; |
There was a problem hiding this comment.
I wonder about leaving this blank, but having an empty field might be more frustrating for people
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is not meant to be merged in. It is a review-only pull request for specific regions of code.
Codebase regions for review
ws_sdcard- for interfacing with a micro SD Card breakout.parseConfigFilefunctions and looksBuildJSONDocandLogJSONDocAPI interfaces are present for each type of componentws_sdcardand mode-switching (determining whether the device is online or offline) withinWipperSnapper_V2class in two functions -provision()andconnect()FS_V2andLittleFS_V2network_interfaces/toadapters/to allow for a WipperSnapper device without a network interface (offline/).adapters/offline/ws_offline_picoto support a Raspberry Pi in offline mode.Workflow enhancements for review:
run-tests.yml, to automate testing using Wokwi.